-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vertProperties behavior #536
Comments
Ah yes, indeed I haven't gotten around to 2 yet. There's a bunch of stuff I want to do to improve smoothing as well. For 3, no it should not copy the properties because they're identical. Better to reference them and keep the memory down. I don't think we make any assumptions about how verts and property verts relate to each other. Agreed, regarding the need for better docs. |
oh ok, for 3 I think I mixed up the MeshGL interface and our internal representation a bit, I thought we have properties for each vertex. |
2 is fixed by #741 |
manifold/src/manifold/src/smoothing.cpp
Lines 458 to 472 in 1514c15
manifold/src/manifold/src/edge_op.cpp
Lines 324 to 342 in 1514c15
The text was updated successfully, but these errors were encountered: