Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file conversion and debug utility #407

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Added file conversion and debug utility #407

merged 3 commits into from
Apr 11, 2023

Conversation

elalish
Copy link
Owner

@elalish elalish commented Apr 11, 2023

Added convertFile executable to extras, which helps with things like #388. I also added some more verbose logging which demonstrates the cause of that problem is our edge collapse getting a bit too excited.

@elalish elalish self-assigned this Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.07 ⚠️

Comparison is base (3a517a4) 86.08% compared to head (794cf5f) 86.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
- Coverage   86.08%   86.02%   -0.07%     
==========================================
  Files          38       38              
  Lines        4572     4580       +8     
==========================================
+ Hits         3936     3940       +4     
- Misses        636      640       +4     
Impacted Files Coverage Δ
meshIO/include/meshIO.h 100.00% <ø> (ø)
src/manifold/src/edge_op.cpp 97.60% <50.00%> (-1.35%) ⬇️
src/polygon/src/polygon.cpp 86.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@elalish elalish merged commit a9bf836 into master Apr 11, 2023
@elalish elalish deleted the importCorruption branch April 11, 2023 18:38
@elalish elalish mentioned this pull request Nov 3, 2023
cartesian-theatrics pushed a commit to SovereignShop/manifold that referenced this pull request Mar 11, 2024
* added file conversion utility

* added verbose output

* fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant