OTel bridge enhancements #2172
Merged
OTel bridge enhancements #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
previously approved these changes
Aug 31, 2023
We should simply expect this to be part of the apm-data work and it will be mapped there at some point. Until then, the value appears in a label.
stevejgordon
force-pushed
the
otel-bridge-optimisations
branch
from
d68f43b
to
27776a8
Compare
Mpdreamz
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from ##2157, this updates the remainder of the bridge to prefer reading attributes from
TagObjects. It also removes theElasticSearchHttpNonTraceras we have decided we want to capture HTTP spans for the physical HTTP calls under a logical Elasticsearch operation span.Closes #2154