Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OnExecuteRequestStep available in new .NET versions for IIS modules. #2196

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

Mpdreamz
Copy link
Member

This more aggressively logs and attempts to restore HttpContext items.

This also more gracefully exits if we detect the module running under classic pipeline mode

…odules.

This more aggressively logs and attempts to restore HttpContext items.

This also more gracefully exits if we detect the module running under classic pipeline mode
stevejgordon
stevejgordon previously approved these changes Oct 17, 2023
Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz
Copy link
Member Author

@stevejgordon I updated this slightly to include the url in the log output. Also we no longer log these steps on urls we'd later ignore anyway.

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mpdreamz Mpdreamz merged commit 35a9fcf into main Oct 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants