Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyless Azure Auth in test-linux #2384

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Keyless Azure Auth in test-linux #2384

merged 5 commits into from
Jun 28, 2024

Conversation

reakaleek
Copy link
Member

@reakaleek reakaleek commented Jun 27, 2024

Use OIDC to login to azure.

@reakaleek
Copy link
Member Author

reakaleek commented Jun 27, 2024

I will disable the azure-tests job again.

But I was able to validate that the OIDC login works and terraform resources are created as expected in https:/elastic/apm-agent-dotnet/actions/runs/9700716496/job/26773022726

P.S. I found many tests failing after a timeout of 15 minutes..

Maybe we want to increase:

private static readonly TimeSpan _defaultTimeout = TimeSpan.FromMinutes(15);

In Terraform, the delete timeout is actually set to 180 minutes. So I suspect that it needs more time. Source: https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/cosmosdb_account#timeouts

@reakaleek reakaleek requested review from Mpdreamz and v1v June 27, 2024 19:16
@reakaleek reakaleek marked this pull request as ready for review June 27, 2024 19:16
@reakaleek reakaleek requested a review from v1v June 28, 2024 07:51
@reakaleek reakaleek mentioned this pull request Jun 28, 2024
@reakaleek reakaleek merged commit 2b897d0 into main Jun 28, 2024
15 checks passed
@reakaleek reakaleek deleted the feature/keyless-azure-auth branch June 28, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants