Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure libbeat does not set host.name #1846

Closed
simitt opened this issue Jan 28, 2019 · 6 comments · Fixed by elastic/beats#10728 or #1934
Closed

Ensure libbeat does not set host.name #1846

simitt opened this issue Jan 28, 2019 · 6 comments · Fixed by elastic/beats#10728 or #1934
Assignees
@simitt
Labels
bug
Milestone
7.0

Comments

@simitt
Copy link
Contributor

simitt commented Jan 28, 2019

Look into how setting host.name can be prevented. Easiest fix seems to overwrite it by the
APM Server.

Note: Remove excluding the host from the system approval tests afterwards.
@simitt simitt added this to the 7.0 milestone Jan 28, 2019
@simitt simitt added the bug label Jan 28, 2019
@simitt simitt mentioned this issue Jan 28, 2019
Merged
@simitt simitt self-assigned this Feb 5, 2019
@simitt
Copy link
Contributor Author

simitt commented Feb 5, 2019

Currently libbeat sets a host.name, which is not accurate for APM, as the host should reflect the host where the monitored service is running and not the APM Server.
This is a similar issue to what we had with agent metadata information, that has been solved by using a processor. According to elastic/beats#9952 (comment) we should not necessarily use processors for this. @urso is there any other way we can solve this already or are you fine with introducing another processor for this?

@urso
Copy link

urso commented Feb 11, 2019

The host.name field is set in 2 locations in Beats:

  • by the publisher pipeline
  • via add_host_metadata processor

The processor is enabled by default for all beats.

I assume you don't want to have any of these default processors enabled? I think it would make sense to remove the field from the publisher pipelines builtin fields.

@simitt simitt mentioned this issue Feb 13, 2019
Merged
@simitt
Copy link
Contributor Author

simitt commented Feb 13, 2019 •
edited
Loading

depending on elastic/beats#10728

@simitt simitt reopened this Feb 15, 2019
@simitt
Copy link
Contributor Author

simitt commented Feb 15, 2019

As pointed out in an offline discussion by @urso, the implemented solution had some side effect on beats xpack monitoring. Thus the PR in libbeat got reverted and @urso will refactor the current handling and provide a fix from libbeat.

simitt added a commit to simitt/apm-server that referenced this issue Feb 18, 2019
@simitt
Use SkipHostName to avoid setting host.name.
487cbe3 
fixes elastic#1846
@simitt simitt mentioned this issue Feb 18, 2019
Merged
simitt added a commit to simitt/apm-server that referenced this issue Feb 18, 2019
@simitt
Use SkipHostName to avoid setting host.name.
faf3b20 
fixes elastic#1846
simitt added a commit to simitt/apm-server that referenced this issue Feb 18, 2019
@simitt
Use SkipHostName to avoid setting host.name.
fefbe24 
fixes elastic#1846
@zube zube bot added the [zube]: Done label Feb 20, 2019
@simitt simitt reopened this Feb 20, 2019
@simitt
Copy link
Contributor Author

simitt commented Mar 11, 2019

Unblocked as elastic/beats#10801 got merged and backported to 7.0

simitt added a commit to simitt/apm-server that referenced this issue Mar 11, 2019
@simitt
Adapt beat root cmd to processor changes.
93a21f5 
fixes elastic#1846
@simitt simitt mentioned this issue Mar 11, 2019
Merged
simitt added a commit to simitt/apm-server that referenced this issue Mar 11, 2019
@simitt
Adapt beat root cmd to processor changes.
cca06f2 
fixes elastic#1846
simitt added a commit to simitt/apm-server that referenced this issue Mar 11, 2019
@simitt
Adapt beat root cmd to processor changes.
a5ada2f 
fixes elastic#1846
simitt added a commit to simitt/apm-server that referenced this issue Mar 12, 2019
@simitt
Adapt beat root cmd to processor changes.
8d4cdb6 
fixes elastic#1846
simitt added a commit to simitt/apm-server that referenced this issue Mar 12, 2019
@simitt
Adapt beat root cmd to processor changes.
5121f02 
fixes elastic#1846
simitt added a commit to simitt/apm-server that referenced this issue Mar 12, 2019
@simitt
Adapt beat root cmd to processor changes.
5dfe95a 
fixes elastic#1846
simitt added a commit to simitt/apm-server that referenced this issue Mar 12, 2019
@simitt
Adapt beat root cmd to processor changes.
f5821fa 
fixes elastic#1846
simitt added a commit to simitt/apm-server that referenced this issue Mar 12, 2019
@simitt
Adapt beat root cmd to processor changes.
344702b 
fixes elastic#1846
simitt added a commit that referenced this issue Mar 12, 2019
@simitt
[7.0] Update beats framework and adapt to new processor handling. (#1981
79bd7d9 
)

* Update beats to framework 4756ec1.

* Adapt beat root cmd to processor changes.

fixes #1846
@graphaelli
Copy link
Member

fixed on 7.0 by #1981, #1982 is set to fix this on master

@zube zube bot reopened this Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simitt simitt

Labels
bug
Projects
None yet
Milestone
7.0
4 participants
@urso @graphaelli @simitt @alvarolobato