Jaeger grpc system test #3118
Merged
Jaeger grpc system test #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
reviewed
Jan 8, 2020
- Move test to test_jaeger - Use non-default, dynamic port - Check error docs
And reuse it in the system tests.
Codecov Report
@@ Coverage Diff @@
## jaeger #3118 +/- ##
=======================================
Coverage 79.67% 79.67%
=======================================
Files 104 104
Lines 5486 5486
=======================================
Hits 4371 4371
Misses 1115 1115 |
simitt
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3009