Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make list of Access-Control-Allow-Headers configurable. #3299

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

jalvz
Copy link
Contributor

@jalvz jalvz commented Feb 10, 2020

The configurable list is appended to Content-Type, Content-Encoding and Accept, which are allways included.

Closes #2497

  • Needs changelog
  • Needs docs
  • Needs cloud whitelist?

@robgil
Copy link

robgil commented Feb 10, 2020

Codecov Report

Merging #3299 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3299   +/-   ##
=======================================
  Coverage   79.82%   79.82%           
=======================================
  Files         107      107           
  Lines        5625     5627    +2     
=======================================
+ Hits         4490     4492    +2     
  Misses       1135     1135           

The configurable list is appended to Content-Type, Content-Encoding and Accept, which are allways included.
Closes elastic#2497
@jalvz
Copy link
Contributor Author

jalvz commented Feb 11, 2020

fyi @bmorelli25

@axw
Copy link
Member

axw commented Mar 31, 2020

Default configuration:

$ curl -XOPTIONS -v http://localhost:8200/intake/v2/rum/events
...
Access-Control-Allow-Headers: Content-Type, Content-Encoding, Accept
...

With -E apm-server.rum.allow_headers=[Foo,Bar]:

$ curl -XOPTIONS -v http://localhost:8200/intake/v2/rum/events
...
Access-Control-Allow-Headers: Foo, Bar, Content-Type, Content-Encoding, Accept
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide configuration for Access-Control-Allow-Headers response header on the RUM endpoint
4 participants