Makefile: fix update-beats-module #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run `go list ...` in the shell, rather than in Make, to avoid premature expansion.
Codecov Report
@@ Coverage Diff @@
## master #3785 +/- ##
=======================================
Coverage 79.76% 79.76%
=======================================
Files 136 136
Lines 6158 6158
=======================================
Hits 4912 4912
Misses 1246 1246 |
jalvz
approved these changes
May 11, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
axw
added a commit
to axw/apm-server
that referenced
this pull request
May 12, 2020
Run `go list ...` in the shell, rather than in Make, to avoid premature expansion.
axw
added a commit
to axw/apm-server
that referenced
this pull request
May 12, 2020
Run `go list ...` in the shell, rather than in Make, to avoid premature expansion.
axw
added a commit
that referenced
this pull request
May 12, 2020
axw
added a commit
that referenced
this pull request
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Update Make
update-beats-moduletarget to rungo list -m -f {{.Dir}} ...in the shell command, rather than in Make as a shell function, to avoid premature expansion.Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] automated tests (add tests for the code changes, all unit tests pass locally)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
make update-beatsRelated issues
Fixes #3784