Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update beats framework to 6e91ce4988a7 fixes duplicate dynamic template names #3832

Merged
merged 4 commits into from
Jun 2, 2020

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Jun 2, 2020

Motivation/summary

Pull in beats update to fix duplicate name issue for dynamic templates, #2693.

This upgrade also changes the fixed version of k8s.io/client-go to v0.18.3 and upgrades grpc and protobuf libraries to stay compatible with libbeat.

Checklist

- [ ] I have signed the Contributor License Agreement.

I have considered changes for:
- [ ] documentation
- [ ] logging (add log lines, choose appropriate log selector, etc.)
- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)

How to test these changes

see description in beats PR elastic/beats#18849

Related issues

closes #2693

@simitt simitt added the v7.9.0 label Jun 2, 2020
@simitt simitt requested a review from a team June 2, 2020 09:59
@apmmachine
Copy link
Contributor

apmmachine commented Jun 2, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #3832 updated]

  • Start Time: 2020-06-02T10:48:36.048+0000

  • Duration: 45 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 3201
Skipped 146
Total 3347

@codecov-commenter
Copy link

Codecov Report

Merging #3832 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3832      +/-   ##
==========================================
+ Coverage   79.59%   79.64%   +0.04%     
==========================================
  Files         135      135              
  Lines        6142     6142              
==========================================
+ Hits         4889     4892       +3     
+ Misses       1253     1250       -3     
Impacted Files Coverage Δ
beater/jaeger/common.go 78.78% <0.00%> (-6.07%) ⬇️
kibana/connecting_client.go 72.58% <0.00%> (+8.06%) ⬆️

@simitt simitt merged commit eda7143 into elastic:master Jun 2, 2020
@simitt simitt deleted the master-beats-update branch June 2, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using same key in dynamic template leads to overwrites
4 participants