Index page URL as ECS field #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3857 +/- ##
==========================================
+ Coverage 79.73% 79.77% +0.03%
==========================================
Files 135 135
Lines 6158 6175 +17
==========================================
+ Hits 4910 4926 +16
- Misses 1248 1249 +1
|
💔 Build Failed
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
axw
reviewed
Jun 9, 2020
There was a problem hiding this comment.
Just did a glance over, looks good so far.
I'm a little bit on the fence as to whether we should also add http.request.referrer based on page.referer, as suggested in #3827 (comment). Is that semantically correct? Might be worth checking with the RUM devs.
axw
reviewed
Jun 10, 2020
| if fragment := url.Fragment; fragment != "" { | ||
| out.Fragment = &fragment | ||
| } | ||
| host, port, err := net.SplitHostPort(url.Host) |
There was a problem hiding this comment.
aha, nice, we get this fixed as a bonus :)
axw
approved these changes
Jun 10, 2020
| @@ -102,6 +102,7 @@ func transactionRequiredKeys() *tests.Set { | |||
| "transaction.type", | |||
| "transaction.context.request.method", | |||
| "transaction.context.request.url", | |||
| //"transaction.context.page.url", | |||
jalvz
added a commit
to jalvz/apm-server
that referenced
this pull request
Jun 10, 2020
* Split Page URL into ECS parts and store it separately * Store page referer separately as ECS field * Update changelog
This was referenced Jun 10, 2020
Merged
jalvz
added a commit
that referenced
this pull request
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
See:
Closes #3827
Checklist
I have considered changes for:
How to test these changes
Index a RUM event with something in
context.page, and see it indexed as ECS fields inurlandhttp.request.referrer.Note: if agent sends
context.request.url, that will be used for theurlfield, and not the page