Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apmpackage: disallow multiple policies #4694

Merged
merged 3 commits into from
Feb 9, 2021

Conversation

axw
Copy link
Member

@axw axw commented Feb 8, 2021

Motivation/summary

Prevent the APM integration from being added multiple times to an agent policy.

Requires #4693

How to test these changes

  1. Install apm integration
  2. Add apm integration to an agent policy
  3. Attempt to add another integration to the agent policy, apm integration will no longer be an option

Related issues

Closes #4539

@apmmachine
Copy link
Contributor

apmmachine commented Feb 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #4694 updated

  • Start Time: 2021-02-09T06:02:51.590+0000

  • Duration: 42 min 27 sec

  • Commit: 2e312ef

Test stats 🧪

Test Results
Failed 0
Passed 4628
Skipped 124
Total 4752

Trends 🧪

Image of Build Times

Image of Tests

Steps errors 3

Expand to view the steps failures

Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=coverage-files.tgz -czf coverage-files.tgz coverage
Compress
  • Took 0 min 0 sec . View more details on here
  • Description: tar --exclude=system-tests-linux-files.tgz -czf system-tests-linux-files.tgz system-tests
Test Sync
  • Took 4 min 45 sec . View more details on here
  • Description: ./.ci/scripts/sync.sh

@axw axw marked this pull request as ready for review February 8, 2021 08:13
@codecov-io
Copy link

Codecov Report

Merging #4694 (fbb624c) into master (e232606) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4694   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files         163      163           
  Lines        9914     9914           
=======================================
  Hits         7559     7559           
  Misses       2355     2355           
Impacted Files Coverage Δ
...ack/apm-server/aggregation/txmetrics/aggregator.go 93.36% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Elastic Agent] Only allow installing APM Server once per policy
4 participants