Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.13] ingest: translate known OpenTelemetry JVM metrics (backport #4986) #5165

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 27, 2021

This is an automatic backport of pull request #4986 done by Mergify.

Cherry-pick of 264d151 has failed:

On branch mergify/bp/7.13/pr-4986
Your branch is up to date with 'origin/7.13'.

You are currently cherry-picking commit 264d15147.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   changelogs/7.13.asciidoc
	both modified:   docs/configuring-ingest.asciidoc
	both modified:   systemtest/otlp_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

* ingest: translate known OpenTelemetry JVM metrics

Copy well-known JVM metrics from their OpenTelemetry
names and associated labels to their counterparts
produced by the Elastic APM Java agent. This enables
users to visualise the metrics in the Elastic APM
app in Kibana.

Metrics are duplicated to avoid surprising users by
silently dropping the OpenTelemetry names. Users can
drop either one of the duplicates with ingest pipeline
customisation.

* Add changelog

* docs: document new ingest pipelines

* docs: move existing docs to correct position

* ingest: address review comments

- Move `runtime.jvm.gc.collection` before `runtime.jvm.gc.time`
- Require `ctx.runtime?.jvm?.gc != null` when copying `labels.gc`

* Regenerate integration package

(cherry picked from commit 264d151)

# Conflicts:
#	changelogs/7.13.asciidoc
#	docs/configuring-ingest.asciidoc
#	systemtest/otlp_test.go
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Apr 27, 2021
@mergify mergify bot assigned axw Apr 27, 2021
@apmmachine
Copy link
Contributor

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #5165 opened

  • Start Time: 2021-04-27T12:48:31.762+0000

  • Duration: 7 min 48 sec

  • Commit: 1df6c1a

Trends 🧪

Image of Build Times

Steps errors 1

Expand to view the steps failures

Run intake
  • Took 3 min 11 sec . View more details on here
  • Description: ./.ci/scripts/intake.sh

Log output

Expand to view the last 100 lines of log output

[2021-04-27T12:54:36.012Z] go: downloading github.com/kevinburke/ssh_config v0.0.0-20190725054713-01f96b0aa0cd
[2021-04-27T12:54:36.012Z] go: downloading gopkg.in/warnings.v0 v0.1.2
[2021-04-27T12:54:36.012Z] go: downloading github.com/go-stack/stack v1.8.0
[2021-04-27T12:54:48.293Z] Formatting apmpackage/apm/0.2.0
[2021-04-27T12:54:48.293Z] elastic-package has been installed.
[2021-04-27T12:54:48.293Z] Format the package
[2021-04-27T12:54:48.293Z] Done
[2021-04-27T12:54:48.293Z] Building apmpackage/apm/0.2.0
[2021-04-27T12:54:48.293Z] Build the package
[2021-04-27T12:54:48.293Z] Package built: /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5165/src/github.com/elastic/apm-server/build/integrations/apm/0.2.0
[2021-04-27T12:54:48.293Z] Done
[2021-04-27T12:54:48.293Z] go: downloading github.com/dgraph-io/badger v1.6.2
[2021-04-27T12:54:48.293Z] go: downloading github.com/elastic/go-hdrhistogram v0.1.0
[2021-04-27T12:54:48.293Z] go: downloading github.com/elastic/go-windows v1.0.1
[2021-04-27T12:54:48.293Z] go: downloading github.com/inconshreveable/mousetrap v1.0.0
[2021-04-27T12:54:48.293Z] go: downloading github.com/aws/aws-sdk-go-v2 v0.18.0
[2021-04-27T12:54:48.554Z] go: downloading github.com/hashicorp/nomad/api v0.0.0-20200303134319-e31695b5bbe6
[2021-04-27T12:54:48.554Z] go: downloading github.com/dgraph-io/badger/v2 v2.2007.3-0.20201012072640-f5a7e0a1c83b
[2021-04-27T12:54:48.554Z] go: downloading github.com/hashicorp/go-rootcerts v1.0.2
[2021-04-27T12:54:48.554Z] go: downloading github.com/gorhill/cronexpr v0.0.0-20180427100037-88b0669f7d75
[2021-04-27T12:54:48.554Z] go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
[2021-04-27T12:54:48.554Z] go: downloading github.com/dgraph-io/ristretto v0.0.3-0.20200630154024-f66de99634de
[2021-04-27T12:54:48.816Z] go: downloading github.com/DataDog/zstd v1.4.4
[2021-04-27T12:54:48.816Z] go: downloading github.com/Microsoft/go-winio v0.4.16
[2021-04-27T12:54:48.816Z] go: downloading github.com/gorilla/websocket v1.4.2
[2021-04-27T12:54:48.816Z] go: downloading github.com/konsorten/go-windows-terminal-sequences v1.0.3
[2021-04-27T12:54:48.816Z] go: downloading code.cloudfoundry.org/go-loggregator v7.4.0+incompatible
[2021-04-27T12:54:48.816Z] go: downloading github.com/cloudfoundry-community/go-cfclient v0.0.0-20190808214049-35bcce23fc5f
[2021-04-27T12:54:48.816Z] go: downloading github.com/ugorji/go v1.1.8
[2021-04-27T12:54:49.079Z] go: downloading github.com/ugorji/go/codec v1.1.8
[2021-04-27T12:54:49.079Z] go: downloading github.com/cloudfoundry/sonde-go v0.0.0-20171206171820-b33733203bb4
[2021-04-27T12:54:49.079Z] go: downloading github.com/cloudfoundry/noaa v2.1.0+incompatible
[2021-04-27T12:54:49.079Z] go: downloading github.com/dgryski/go-farm v0.0.0-20200201041132-a6ae2369ad13
[2021-04-27T12:54:49.079Z] go: downloading github.com/mailru/easyjson v0.7.6
[2021-04-27T12:54:49.079Z] go: downloading code.cloudfoundry.org/gofileutils v0.0.0-20170111115228-4d0c80011a0f
[2021-04-27T12:54:49.079Z] go: downloading code.cloudfoundry.org/rfc5424 v0.0.0-20180905210152-236a6d29298a
[2021-04-27T12:54:49.079Z] go: downloading code.cloudfoundry.org/go-diodes v0.0.0-20190809170250-f77fb823c7ee
[2021-04-27T12:54:49.079Z] go: downloading github.com/josharian/intern v1.0.0
[2021-04-27T12:54:52.388Z] go: downloading github.com/jmespath/go-jmespath v0.4.0
[2021-04-27T12:54:54.948Z] go: downloading go.elastic.co/go-licence-detector v0.5.0
[2021-04-27T12:54:55.523Z] go: downloading github.com/cyphar/filepath-securejoin v0.2.2
[2021-04-27T12:54:55.523Z] go: downloading golang.org/x/mod v0.4.0
[2021-04-27T12:54:55.523Z] go: downloading github.com/markbates/pkger v0.17.0
[2021-04-27T12:54:55.523Z] go: downloading github.com/google/licenseclassifier v0.0.0-20200402202327-879cb1424de0
[2021-04-27T12:54:55.523Z] go: downloading github.com/karrick/godirwalk v1.15.6
[2021-04-27T12:54:55.523Z] go: downloading github.com/gobuffalo/here v0.6.0
[2021-04-27T12:55:05.550Z] /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5165/src/github.com/elastic/apm-server/NOTICE.txt
[2021-04-27T12:55:05.550Z] 2021/04/27 12:55:04 exec: go list -m
[2021-04-27T12:55:05.550Z] >> Building apm-server.yml for linux/amd64
[2021-04-27T12:55:05.551Z] >> Building apm-server.docker.yml for linux/amd64
[2021-04-27T12:55:06.500Z] Generated fields.yml for apm-server to /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5165/src/github.com/elastic/apm-server/build/fields/fields.yml
[2021-04-27T12:55:07.447Z] Generated fields.yml for apm-server to /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5165/src/github.com/elastic/apm-server/build/fields/fields.all.yml
[2021-04-27T12:55:10.001Z] /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5165/.gvm/versions/go1.15.9.linux.amd64/bin/go build -o build/linux/goimports golang.org/x/tools/cmd/goimports
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:34:1: expected 'STRING', found '<<'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:37:73: illegal character U+0023 '#'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:52:1: expected 'STRING', found 'var'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:57:3: expected 'STRING', found 'if'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:58:4: expected 'STRING', found 'return'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:59:3: expected 'STRING', found '}'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:60:3: expected 'STRING', found 'select'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:72:2: expected 'STRING', found 'defer'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:94:2: expected 'STRING', found 'defer'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:101:73: illegal character U+0023 '#'
[2021-04-27T12:55:10.948Z] systemtest/otlp_test.go:129:2: expected 'STRING', found 'defer'
[2021-04-27T12:55:13.504Z] Makefile:251: recipe for target 'check-gofmt' failed
[2021-04-27T12:55:13.504Z] make: *** [check-gofmt] Error 2
[2021-04-27T12:55:13.504Z] + cleanup
[2021-04-27T12:55:13.504Z] + rm -rf /tmp/tmp.XY3zb3eP7f
[2021-04-27T12:55:15.151Z] Stage "Build and Test" skipped due to earlier failure(s)
[2021-04-27T12:55:15.780Z] Stage "linux build" skipped due to earlier failure(s)
[2021-04-27T12:55:15.801Z] Stage "windows build-test" skipped due to earlier failure(s)
[2021-04-27T12:55:15.823Z] Stage "OSX build-test" skipped due to earlier failure(s)
[2021-04-27T12:55:15.844Z] Stage "Unit Test" skipped due to earlier failure(s)
[2021-04-27T12:55:15.865Z] Stage "System and Environment Tests" skipped due to earlier failure(s)
[2021-04-27T12:55:15.886Z] Stage "Benchmarking" skipped due to earlier failure(s)
[2021-04-27T12:55:15.909Z] Stage "Check kibana Obj. Updated" skipped due to earlier failure(s)
[2021-04-27T12:55:15.929Z] Stage "Hey-Apm" skipped due to earlier failure(s)
[2021-04-27T12:55:15.950Z] Stage "Package" skipped due to earlier failure(s)
[2021-04-27T12:55:15.962Z] Stage "APM Integration Tests" skipped due to earlier failure(s)
[2021-04-27T12:55:16.087Z] Stage "Package" skipped due to earlier failure(s)
[2021-04-27T12:55:16.572Z] Failed in branch linux build
[2021-04-27T12:55:16.588Z] Failed in branch windows build-test
[2021-04-27T12:55:16.606Z] Failed in branch OSX build-test
[2021-04-27T12:55:16.622Z] Failed in branch Unit Test
[2021-04-27T12:55:16.638Z] Failed in branch System and Environment Tests
[2021-04-27T12:55:16.654Z] Failed in branch Benchmarking
[2021-04-27T12:55:16.669Z] Failed in branch Check kibana Obj. Updated
[2021-04-27T12:55:16.685Z] Failed in branch Hey-Apm
[2021-04-27T12:55:16.702Z] Failed in branch APM Integration Tests
[2021-04-27T12:55:16.843Z] Stage "Package" skipped due to earlier failure(s)
[2021-04-27T12:55:17.141Z] Failed in branch Package
[2021-04-27T12:55:18.200Z] Running on Jenkins in /var/lib/jenkins/workspace/pm-server_apm-server-mbp_PR-5165
[2021-04-27T12:55:18.430Z] [INFO] getVaultSecret: Getting secrets
[2021-04-27T12:55:18.511Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2021-04-27T12:55:19.818Z] + chmod 755 generate-build-data.sh
[2021-04-27T12:55:19.818Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5165/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5165/runs/1 FAILURE 407772
[2021-04-27T12:55:19.818Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5165/runs/1/steps/?limit=10000 -o steps-info.json
[2021-04-27T12:55:20.069Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-server/apm-server-mbp/PR-5165/runs/1/tests/?status=FAILED -o tests-errors.json
[2021-04-27T12:55:20.069Z] Retry 1/3 exited 22, retrying in 1 seconds...
[2021-04-27T12:55:20.980Z] Retry 2/3 exited 22, retrying in 2 seconds...

@jalvz jalvz closed this Apr 27, 2021
@mergify mergify bot deleted the mergify/bp/7.13/pr-4986 branch April 27, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants