processor/otel: handle net.host.* as span attributes #5719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were mistakenly handling the new net.host attributes as resource attributes, whereas they should be span attributes; these fields describe a network connection, which will be specific to an operation (span), and not the service (resource) performing that operation. `net.host.connection_type` has been updated to `net.host.connection.type`, per the spec change.
axw
added
v7.14.0
v7.15.0
backport-7.14
axw
changed the title
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
approved these changes
Jul 15, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
We were mistakenly handling the new net.host attributes as resource attributes, whereas they should be span attributes; these fields describe a network connection, which will be specific to an operation (span), and not the service (resource) performing that operation. `net.host.connection_type` has been updated to `net.host.connection.type`, per the spec change. (cherry picked from commit 61bf74d)
mergify bot
pushed a commit
that referenced
this pull request
Jul 15, 2021
We were mistakenly handling the new net.host attributes as resource attributes, whereas they should be span attributes; these fields describe a network connection, which will be specific to an operation (span), and not the service (resource) performing that operation. `net.host.connection_type` has been updated to `net.host.connection.type`, per the spec change. (cherry picked from commit 61bf74d)
axw
added a commit
that referenced
this pull request
Jul 15, 2021
We were mistakenly handling the new net.host attributes as resource attributes, whereas they should be span attributes; these fields describe a network connection, which will be specific to an operation (span), and not the service (resource) performing that operation. `net.host.connection_type` has been updated to `net.host.connection.type`, per the spec change. (cherry picked from commit 61bf74d) Co-authored-by: Andrew Wilkins <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
axw
added a commit
that referenced
this pull request
Jul 15, 2021
We were mistakenly handling the new net.host attributes as resource attributes, whereas they should be span attributes; these fields describe a network connection, which will be specific to an operation (span), and not the service (resource) performing that operation. `net.host.connection_type` has been updated to `net.host.connection.type`, per the spec change. (cherry picked from commit 61bf74d) Co-authored-by: Andrew Wilkins <[email protected]>
|
Running from the latest |
|
Probably because elastic/apm-agent-ios#46 hasn't landed yet. I think we should just follow up on this in 7.15, seeing as there's more to do anyway. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
We were mistakenly handling the new
net.host.*attributes as resource attributes, whereas they should be span attributes. These fields describe a network connection which will be specific to an operation (span), and not the service (resource) performing that operation.net.host.connection_typehas been updated tonet.host.connection.type, per the spec change.Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
When elastic/apm-agent-ios#46 lands, run a program instrumented with the iOS agent, and check that the information is indexed into
network.*fields and not as labels. The only field that should show up as a label isnet.host.connection.subtype, which is not yet mapped.Related issues
#5436