Introduce model.Trace #5983
Merged
Introduce model.Trace #5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce type model.Trace and field APMEvent.Trace,
replacing {Error,Span,Transaction}.TraceID.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
simitt
approved these changes
Aug 23, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 24, 2021
Introduce type model.Trace and field APMEvent.Trace,
replacing {Error,Span,Transaction}.TraceID.
(cherry picked from commit 6754818)
axw
added a commit
that referenced
this pull request
Aug 24, 2021
Introduce type model.Trace and field APMEvent.Trace,
replacing {Error,Span,Transaction}.TraceID.
(cherry picked from commit 6754818)
Co-authored-by: Andrew Wilkins <[email protected]>
marclop
added
backport-skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Introduce type
model.Traceand fieldmodel.APMEvent.Trace, replacing{Error,Span,Transaction}.TraceID. This will make it more straightforward to includetrace.idin log events, for #4715.Checklist
- [ ] Update CHANGELOG.asciidoc- [ ] Documentation has been updatedHow to test these changes
Non-functional change.
Related issues
#4410
#4120
#4715