Skip to content

Commit

Permalink
add changelog and improve messages
Browse files Browse the repository at this point in the history
  • Loading branch information
belimawr committed Oct 18, 2024
1 parent e4e1c62 commit 1a91677
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ https:/elastic/beats/compare/v8.8.1\...main[Check the HEAD diff]
- Fixed failed job handling and removed false-positive error logs in the GCS input. {pull}41142[41142]
- Bump github.com/elastic/go-sfdc dependency used by x-pack/filebeat/input/salesforce. {pull}41192[41192]
- Log bad handshake details when websocket connection fails {pull}41300[41300]
- Journald input now can read events from all boots {issue}41083[41083] {pull}41244[41244]

*Heartbeat*

Expand Down
5 changes: 3 additions & 2 deletions filebeat/input/journald/pkg/journalctl/reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@ type Reader struct {
// the journalctl process
jctlLogger *logp.Logger

// args are arguments for journalctl that never change
// args are arguments for journalctl that never change,
// like the message filters, format, etc
args []string

// firstRunArgs are the arguments used in the first call to
Expand Down Expand Up @@ -359,7 +360,7 @@ func (r *Reader) handleMessage(msg []byte) (JournalEntry, error) {
"look at the events log file for the raw journal event")

// Log raw data to events log file
msg := fmt.Sprintf("data cannot be parsed as map[string]any JSON: '%s'",
msg := fmt.Sprintf("data cannot be parsed as map[string]any. Data: '%s'",
string(msg))
r.logger.Errorw(
msg,
Expand Down

0 comments on commit 1a91677

Please sign in to comment.