Diskio metricset errors with shared drives under Windows

[adriansr]

For confirmed bugs, please report:

• Version: 7.10.1
• Operating System: Windows 2016
• Discuss Forum URL:
• Steps to Reproduce:

1. Run the diskio metricset with a shared drive (for example net use Z: \\vboxsvr\vagrant)
2. The following error is printed to the logs every time the metricset is run:

ERROR diskio/diskstat_windows_helper.go:89 Could not return any performance counter values for \.\Z: .Error: Incorrect function.

It could potentially just skip network drives as I understand there aren't perf counters for those, or lower the message severity.

[elasticmachine]

Pinging @elastic/integrations-services (Team:Services)

[adriansr]

@narph @fearful-symmetry I see you've been working on this metricset lately, maybe you can take this.

[fearful-symmetry]

@narph would be best, I don't really have any knowledge of windows-specific functions that are failing out here.

[elasticmachine]

Pinging @elastic/integrations-platforms (Team:Platforms)

[fearful-symmetry]

@narph this got fixed, right? I remember us tinkering with the disk reporting a while back. Assuming it is, and moving to backlog for now.

[narph]

@adriansr , I've recently fixed this with #24502, do you encounter the same issue with 7.12.1?

[adriansr]

Hi @narph, I haven't tested this again since this issue was created. If you're confident that it was fixed then we can close.

[narph]

@adriansr. just noticed this is a different metricset, I created a similar fix for filesystem, will try to reproduce the issue and make the necessary changes, lets keep it open

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[botelastic]

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!