-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover possible processor re-use with tests #34783
Labels
Comments
rdner
added
enhancement
Filebeat
Filebeat
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
labels
Mar 8, 2023
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
It would be good to pair this with #34792, to identify why the Beat becomes non-functional and generates a seemingly infinite number of processing errors when a processor is reused so we can introduce a more graceful failure mode if this happens again. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the enhancement:
We caught a high-impact bug recently #34761 and we need to introduce some testing in order to prevent this bug from reappearing. Or even to make sure we've fixed all the occurrences.
It should be enough to:
SafeProcessor
wrapper #34647 and before Stop re-using processors defined in the config #34761 this should return an erroralso, before both changes calling
Close
twice would cause a panic onadd_kubernetes_metadata
.The test should reproduce the issue on the old code before being accepted.
The text was updated successfully, but these errors were encountered: