Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover possible processor re-use with tests #34783

Closed
rdner opened this issue Mar 8, 2023 · 2 comments · Fixed by #34870
Closed

Cover possible processor re-use with tests #34783

rdner opened this issue Mar 8, 2023 · 2 comments · Fixed by #34870
Assignees
Labels
enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@rdner
Copy link
Member

rdner commented Mar 8, 2023

Describe the enhancement:

We caught a high-impact bug recently #34761 and we need to introduce some testing in order to prevent this bug from reappearing. Or even to make sure we've fixed all the occurrences.

It should be enough to:

also, before both changes calling Close twice would cause a panic on add_kubernetes_metadata.

The test should reproduce the issue on the old code before being accepted.

@rdner rdner added enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Mar 8, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@cmacknz
Copy link
Member

cmacknz commented Mar 9, 2023

It would be good to pair this with #34792, to identify why the Beat becomes non-functional and generates a seemingly infinite number of processing errors when a processor is reused so we can introduce a more graceful failure mode if this happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Filebeat Filebeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants