Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop default version qualifier #8384

Closed
graphaelli opened this issue Sep 20, 2018 · 1 comment
Closed

drop default version qualifier #8384

graphaelli opened this issue Sep 20, 2018 · 1 comment
Assignees
@ph
Labels
:Infra Packaging

Comments

@graphaelli
Copy link
Member

#8310 added a version qualifier, including a default for 7.0.0, for use during the build system transition. This serves as a reminder to remove the default for 7.0.0, though it's unclear whether we'll want that back for 8.x.

While changing this up, let's also drop the BEAT_ prefix from the env variable, leaving just VERSION_QUALIFIER.
@ph ph added the Packaging label Sep 21, 2018
@andrewkroh
Copy link
Member

dev-tools/jenkins_release.sh will need updated too. #8542

@andrewkroh andrewkroh mentioned this issue Nov 17, 2018
Merged
@ph ph mentioned this issue Nov 19, 2018
Merged
@ph ph self-assigned this Nov 19, 2018
@ph ph closed this as completed in #9148 Nov 19, 2018
ph added a commit that referenced this issue Nov 19, 2018
@ph
Never default to a qualifier when none of them are set. (#9148)
0697bc6 
Remove default version qualifier and rename the environment variable to set it from `BEAT_VERSION_QUALIFIER` to `VERSION_QUALIFIER` this will align with other parts of the stack.

**Tested with filebeat.**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:39:01]
filebeat version 7.0.0 (amd64), libbeat 7.0.0 [0a0c267 built 2018-11-19 13:38:15 +0000 UTC]
```

**Without the patch**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:40:07]
filebeat version 7.0.0-alpha1 (amd64), libbeat 7.0.0-alpha1 [b007837 built 2018-11-19 13:39:59 +0000 UTC]
```

Fixes: #8384
kaiyan-sheng added a commit that referenced this issue Dec 17, 2018
@kaiyan-sheng
Add DeDot in add_docker_metadata processor (#9505)
58573a9 
* Never default to a qualifier when none of them are set. (#9148)

Remove default version qualifier and rename the environment variable to set it from `BEAT_VERSION_QUALIFIER` to `VERSION_QUALIFIER` this will align with other parts of the stack.

**Tested with filebeat.**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:39:01]
filebeat version 7.0.0 (amd64), libbeat 7.0.0 [0a0c267 built 2018-11-19 13:38:15 +0000 UTC]
```

**Without the patch**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:40:07]
filebeat version 7.0.0-alpha1 (amd64), libbeat 7.0.0-alpha1 [b007837 built 2018-11-19 13:39:59 +0000 UTC]
```

Fixes: #8384

* Add DeDot in add_docker_metadata processor

* Add dedot into config and default to be false

* Update changelog and documentation

* Add documentation into processors-using.asciidoc

* Run mage fmt update under x-pack filebeat

* Run mage fmt update on x-pack metricbeat

* Run update again

* Run make update fmt from top level dir

* Remove mistakes from rebase

* Remove repeated doc
@kaiyan-sheng kaiyan-sheng mentioned this issue Dec 17, 2018
Closed
kaiyan-sheng added a commit that referenced this issue Dec 31, 2018
@kaiyan-sheng
Fix mysql slowlog template to support mysql 5.7.22 (#9647)
b29ddfc 
* Never default to a qualifier when none of them are set. (#9148)

Remove default version qualifier and rename the environment variable to set it from `BEAT_VERSION_QUALIFIER` to `VERSION_QUALIFIER` this will align with other parts of the stack.

**Tested with filebeat.**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:39:01]
filebeat version 7.0.0 (amd64), libbeat 7.0.0 [0a0c267 built 2018-11-19 13:38:15 +0000 UTC]
```

**Without the patch**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:40:07]
filebeat version 7.0.0-alpha1 (amd64), libbeat 7.0.0-alpha1 [b007837 built 2018-11-19 13:39:59 +0000 UTC]
```

Fixes: #8384

* Fix mysql slowlog template to support mysql 5.7.22

* Add changelog

* Remove changes introduced from rebasing that are not related to this change

* Add more log entries to test log file

* Add OR in multiline.pattern to remove # Time from mysql.slowlog.query

* Use CHANGELOG.next.asciidoc instead
@kaiyan-sheng kaiyan-sheng mentioned this issue Jan 2, 2019
Merged
kaiyan-sheng added a commit that referenced this issue Jan 4, 2019
@kaiyan-sheng
Cherry-pick to 6.x: Fix mysql slowlog template to support mysql 5.7.22 (
7e18314 
#9647) (#9843)

* Fix mysql slowlog template to support mysql 5.7.22 (#9647)

* Never default to a qualifier when none of them are set. (#9148)

Remove default version qualifier and rename the environment variable to set it from `BEAT_VERSION_QUALIFIER` to `VERSION_QUALIFIER` this will align with other parts of the stack.

**Tested with filebeat.**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:39:01]
filebeat version 7.0.0 (amd64), libbeat 7.0.0 [0a0c267 built 2018-11-19 13:38:15 +0000 UTC]
```

**Without the patch**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:40:07]
filebeat version 7.0.0-alpha1 (amd64), libbeat 7.0.0-alpha1 [b007837 built 2018-11-19 13:39:59 +0000 UTC]
```

Fixes: #8384

* Fix mysql slowlog template to support mysql 5.7.22

* Add changelog

* Remove changes introduced from rebasing that are not related to this change

* Add more log entries to test log file

* Add OR in multiline.pattern to remove # Time from mysql.slowlog.query

* Use CHANGELOG.next.asciidoc instead

(cherry picked from commit b29ddfc)

* Rerun test with GENERATE=1 and 6.x environment
kaiyan-sheng added a commit that referenced this issue Jan 14, 2019
@kaiyan-sheng
Add Dedot for Kubernetes labels and annotations (#9939)
d5bda76 
* Never default to a qualifier when none of them are set. (#9148)

Remove default version qualifier and rename the environment variable to set it from `BEAT_VERSION_QUALIFIER` to `VERSION_QUALIFIER` this will align with other parts of the stack.

**Tested with filebeat.**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:39:01]
filebeat version 7.0.0 (amd64), libbeat 7.0.0 [0a0c267 built 2018-11-19 13:38:15 +0000 UTC]
```

**Without the patch**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:40:07]
filebeat version 7.0.0-alpha1 (amd64), libbeat 7.0.0-alpha1 [b007837 built 2018-11-19 13:39:59 +0000 UTC]
```

Fixes: #8384

* Add Dedot for Kubernetes labels and annotations

* Add dedot options in libbeat kubernetes metadata

* Update changelog

* Refactor TestGenerateMapStrFromEvent

* Update shared-autodiscover.asciidoc with dedot params

* Add names for each unit test case in event_test.go

* Fix rebase errors
kaiyan-sheng added a commit that referenced this issue Jan 14, 2019
@kaiyan-sheng
Add Dedot for Kubernetes labels and annotations (#9939) (#10039)
6374a9b 
Fixes: #8384

* Add Dedot for Kubernetes labels and annotations

* Add dedot options in libbeat kubernetes metadata

* Update changelog

* Refactor TestGenerateMapStrFromEvent

* Update shared-autodiscover.asciidoc with dedot params

* Add names for each unit test case in event_test.go

* Fix rebase errors

(cherry picked from commit d5bda76)
bashofmann pushed a commit to syseleven/beats that referenced this issue Jan 28, 2019
@kaiyan-sheng @bashofmann
Add Dedot for Kubernetes labels and annotations (elastic#9939) (elast…
988c746 
…ic#10039)

Fixes: elastic#8384

* Add Dedot for Kubernetes labels and annotations

* Add dedot options in libbeat kubernetes metadata

* Update changelog

* Refactor TestGenerateMapStrFromEvent

* Update shared-autodiscover.asciidoc with dedot params

* Add names for each unit test case in event_test.go

* Fix rebase errors

(cherry picked from commit d5bda76)
DStape pushed a commit to DStape/beats that referenced this issue Aug 20, 2019
@kaiyan-sheng
Add DeDot in add_docker_metadata processor (elastic#9505)
b7a0d79 
* Never default to a qualifier when none of them are set. (elastic#9148)

Remove default version qualifier and rename the environment variable to set it from `BEAT_VERSION_QUALIFIER` to `VERSION_QUALIFIER` this will align with other parts of the stack.

**Tested with filebeat.**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:39:01]
filebeat version 7.0.0 (amd64), libbeat 7.0.0 [0a0c267 built 2018-11-19 13:38:15 +0000 UTC]
```

**Without the patch**
```
 ❯ ./filebeat version                                                                                                                                                                                                                                                                                                                                          [08:40:07]
filebeat version 7.0.0-alpha1 (amd64), libbeat 7.0.0-alpha1 [b007837 built 2018-11-19 13:39:59 +0000 UTC]
```

Fixes: elastic#8384

* Add DeDot in add_docker_metadata processor

* Add dedot into config and default to be false

* Update changelog and documentation

* Add documentation into processors-using.asciidoc

* Run mage fmt update under x-pack filebeat

* Run mage fmt update on x-pack metricbeat

* Run update again

* Run make update fmt from top level dir

* Remove mistakes from rebase

* Remove repeated doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ph ph

Labels
:Infra Packaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ph @graphaelli @andrewkroh