Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Make integration tests more generic for modules #11131

Closed
wants to merge 1 commit into from

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Mar 7, 2019

The goal is that each module on its own has less and less code and is more config based. The basic fetch testing we have for each module is moved into a general integration testing and it uses the configuration to figure out which services to start, ports to talk to etc.

This is still WIP and needs quite a bit of cleanup.

The goal is that each module on its own has less and less code and is more config based. The basic fetch testing we have for each module is moved into a general integration testing and it uses the configuration to figure out which services to start, ports to talk to etc.

This is still WIP and needs quite a bit of cleanup.
@ruflin
Copy link
Member Author

ruflin commented Mar 7, 2019

I would like to get #7957 first merged before moving forward with this as I think it will look even simpler with it (and otherwise conflicts with it).

@fearful-symmetry
Copy link
Contributor

I really like this idea.

@ruflin ruflin added the Team:Integrations Label for the Integrations team label Mar 11, 2019
@ruflin ruflin added blocked in progress Pull request is currently in progress. labels Apr 3, 2019
@ruflin ruflin assigned jsoriano and unassigned ruflin Apr 30, 2019
@ruflin
Copy link
Member Author

ruflin commented Apr 30, 2019

@jsoriano As discussed, assigning to you.

@ruflin
Copy link
Member Author

ruflin commented Aug 17, 2021

@jsoriano It would be really nice to have this "unified" but as it went stale for quite some time I suggest I close it for now. Please reopen if you still plan to work on it.

@ruflin ruflin closed this Aug 17, 2021
@ruflin ruflin deleted the general-integration-tests branch August 17, 2021 12:59
@ruflin ruflin restored the general-integration-tests branch August 17, 2021 12:59
@jsoriano
Copy link
Member

This (or something similar) was implemented in #11981.

@zube zube bot removed the [zube]: Done label Nov 16, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b general-integration-tests upstream/general-integration-tests
git merge upstream/master
git push upstream general-integration-tests

@mergify
Copy link
Contributor

mergify bot commented Nov 16, 2021

This pull request does not have a backport label. Could you fix it @ruflin? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation backport-skip Skip notification from the automated backport with mergify blocked in progress Pull request is currently in progress. Metricbeat Metricbeat module Team:Integrations Label for the Integrations team :Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants