Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack: fix dropped errors #13773

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Sep 24, 2019

This PR fixes some dropped errors in tests under the x-pack hierarchy.

@alrs alrs requested a review from a team as a code owner September 24, 2019 00:51
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@fearful-symmetry
Copy link
Contributor

jenkins, test this

@exekias
Copy link
Contributor

exekias commented Nov 22, 2019

jenkins, test this please

ping @narph

narph
narph previously approved these changes Nov 25, 2019
@narph narph dismissed their stale review November 25, 2019 10:18

Missing changelog entry

@narph
Copy link
Contributor

narph commented Nov 25, 2019

@alrs, do you mind adding an entry in the CHANGELOG as well with a short description of the changes, else we can do it for you.

@alrs
Copy link
Contributor Author

alrs commented Nov 25, 2019

CHANGELOG updated, @narph

@narph narph merged commit 157053c into elastic:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants