Make memqueue.Broker internal (now memqueue.broker) #16667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
approved these changes
Feb 27, 2020
|
consider to add a developers changelog entry. |
5 tasks
faec
added a commit
to faec/beats
that referenced
this pull request
Feb 28, 2020
(cherry picked from commit bb1bcb8)
5 tasks
faec
added a commit
to faec/beats
that referenced
this pull request
Feb 28, 2020
(cherry picked from commit bb1bcb8)
blakerouse
pushed a commit
to blakerouse/beats
that referenced
this pull request
Feb 28, 2020
faec
added a commit
that referenced
this pull request
Feb 28, 2020
5 tasks
blakerouse
added a commit
that referenced
this pull request
Mar 2, 2020
* Split up parts into different metricsets. * Add value and container metricsets. * Add documentation. * Revert metricbeat.yml. * Run make update. * Fix documentation add changelog. * Fix bad change in azure module. * Run make update. * Improve reference config. * Document Kibana Space ID setting (#16622) * Document Kibana Space ID setting * Update reference YML files * Update libbeat/docs/shared-kibana-config.asciidoc Co-Authored-By: DeDe Morton <[email protected]> * Updating reference YML files * Adding link to doc Co-authored-by: DeDe Morton <[email protected]> * Remove the special pins type for `ca_sha256` (#16615) We have changed the type from a special custom type to a slice of string. This reduce the number of exposed types and make it easier in general to work with in the tests. * Remove feature.Describer and enhance Details (#16658) * Make memqueue.Broker internal (now memqueue.broker) (#16667) * [docs] Add skeleton files for 7.7 release highlights and breaking changes (#16584) * [Metricbeat] Add vpc metricset for aws module (#16111) * Add vpn into vpc metricset * Add NATGateway and TrasitGateway * Update cisco.asciidoc (#16434) * Update cisco.asciidoc Making Elasticsearch explicit in the instructions * Update docs source in the module dir Co-authored-by: Loek van Gool <[email protected]> * Fix wording in dev guide (#16497) * Added NetBeat (#12612) * Close files earlier when generating fields files (#16681) Fields generator keeps all open files while generating the global fields.yml file. This is not needed and may lead to "too many open files" errors in some environments. * [Metricbeat] Add new module for Redis Enterprise (#16482) Add metricsets: node, proxy * Add doppler_address, uaa_address, rlp_address to config.reference.yml. Co-authored-by: Shaunak Kashyap <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Pier-Hugues Pellerin <[email protected]> Co-authored-by: Steffen Siering <[email protected]> Co-authored-by: Fae Charlton <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]> Co-authored-by: Loek van Gool <[email protected]> Co-authored-by: Harold Schreckengost <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> Co-authored-by: Marcin Tojek <[email protected]>
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Mar 3, 2020
* Split up parts into different metricsets. * Add value and container metricsets. * Add documentation. * Revert metricbeat.yml. * Run make update. * Fix documentation add changelog. * Fix bad change in azure module. * Run make update. * Improve reference config. * Document Kibana Space ID setting (elastic#16622) * Document Kibana Space ID setting * Update reference YML files * Update libbeat/docs/shared-kibana-config.asciidoc Co-Authored-By: DeDe Morton <[email protected]> * Updating reference YML files * Adding link to doc Co-authored-by: DeDe Morton <[email protected]> * Remove the special pins type for `ca_sha256` (elastic#16615) We have changed the type from a special custom type to a slice of string. This reduce the number of exposed types and make it easier in general to work with in the tests. * Remove feature.Describer and enhance Details (elastic#16658) * Make memqueue.Broker internal (now memqueue.broker) (elastic#16667) * [docs] Add skeleton files for 7.7 release highlights and breaking changes (elastic#16584) * [Metricbeat] Add vpc metricset for aws module (elastic#16111) * Add vpn into vpc metricset * Add NATGateway and TrasitGateway * Update cisco.asciidoc (elastic#16434) * Update cisco.asciidoc Making Elasticsearch explicit in the instructions * Update docs source in the module dir Co-authored-by: Loek van Gool <[email protected]> * Fix wording in dev guide (elastic#16497) * Added NetBeat (elastic#12612) * Close files earlier when generating fields files (elastic#16681) Fields generator keeps all open files while generating the global fields.yml file. This is not needed and may lead to "too many open files" errors in some environments. * [Metricbeat] Add new module for Redis Enterprise (elastic#16482) Add metricsets: node, proxy * Add doppler_address, uaa_address, rlp_address to config.reference.yml. Co-authored-by: Shaunak Kashyap <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Pier-Hugues Pellerin <[email protected]> Co-authored-by: Steffen Siering <[email protected]> Co-authored-by: Fae Charlton <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]> Co-authored-by: Loek van Gool <[email protected]> Co-authored-by: Harold Schreckengost <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> Co-authored-by: Marcin Tojek <[email protected]> (cherry picked from commit 07b03a7)
blakerouse
added a commit
that referenced
this pull request
Mar 3, 2020
) * Add cloudfoundry module to metricbeat (#16671) * Split up parts into different metricsets. * Add value and container metricsets. * Add documentation. * Revert metricbeat.yml. * Run make update. * Fix documentation add changelog. * Fix bad change in azure module. * Run make update. * Improve reference config. * Document Kibana Space ID setting (#16622) * Document Kibana Space ID setting * Update reference YML files * Update libbeat/docs/shared-kibana-config.asciidoc Co-Authored-By: DeDe Morton <[email protected]> * Updating reference YML files * Adding link to doc Co-authored-by: DeDe Morton <[email protected]> * Remove the special pins type for `ca_sha256` (#16615) We have changed the type from a special custom type to a slice of string. This reduce the number of exposed types and make it easier in general to work with in the tests. * Remove feature.Describer and enhance Details (#16658) * Make memqueue.Broker internal (now memqueue.broker) (#16667) * [docs] Add skeleton files for 7.7 release highlights and breaking changes (#16584) * [Metricbeat] Add vpc metricset for aws module (#16111) * Add vpn into vpc metricset * Add NATGateway and TrasitGateway * Update cisco.asciidoc (#16434) * Update cisco.asciidoc Making Elasticsearch explicit in the instructions * Update docs source in the module dir Co-authored-by: Loek van Gool <[email protected]> * Fix wording in dev guide (#16497) * Added NetBeat (#12612) * Close files earlier when generating fields files (#16681) Fields generator keeps all open files while generating the global fields.yml file. This is not needed and may lead to "too many open files" errors in some environments. * [Metricbeat] Add new module for Redis Enterprise (#16482) Add metricsets: node, proxy * Add doppler_address, uaa_address, rlp_address to config.reference.yml. Co-authored-by: Shaunak Kashyap <[email protected]> Co-authored-by: DeDe Morton <[email protected]> Co-authored-by: Pier-Hugues Pellerin <[email protected]> Co-authored-by: Steffen Siering <[email protected]> Co-authored-by: Fae Charlton <[email protected]> Co-authored-by: kaiyan-sheng <[email protected]> Co-authored-by: Loek van Gool <[email protected]> Co-authored-by: Harold Schreckengost <[email protected]> Co-authored-by: Jaime Soriano Pastor <[email protected]> Co-authored-by: Marcin Tojek <[email protected]> (cherry picked from commit 07b03a7) * Fix changelog. * Run mage fmt. * Fix imports to have v7. * Run mage fmt update. * Fix changelog.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cleanup:
memqueue.Brokeris not used anywhere outside thememqueuepackage except via its implementation of thequeue.Queueinterface. This PR makes it an explicitly internal type to better isolate the overall queue interface, and renames the associated functionNewBrokertoNewQueue.This does not introduce any functional changes (except to prevent future PRs from accidentally propagating or depending on this internal type).
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works