Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17360 to 7.x: Add regex based cid extractor to add_process_metadata #17462

Merged
merged 2 commits into from
May 8, 2020

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Apr 3, 2020

Cherry-pick of PR #17360 to 7.x branch. Original message:

  • Enhancement

What does this PR do?

Adds regex based cid extractor to add_kubernetes_metadata

Why is it important?

Adds more flexibility and makes possible to bypass bug with kube-proxy cid turning out to be "kube-proxy"

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Relates:
#15947
#17351

Use cases

Screenshots

Logs

* Add regex based cid extractor to add_process_metadata

Co-authored-by: Jako Tinkus <[email protected]>
(cherry picked from commit b92c6c3)
@exekias exekias added the Team:Platforms Label for the Integrations - Platforms team label Apr 8, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@exekias exekias merged commit 0f4fc20 into elastic:7.x May 8, 2020
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team [zube]: Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants