Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization of Logstash service URL #17497

Merged
merged 17 commits into from
Apr 7, 2020

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Apr 4, 2020

What does this PR do?

This PR fixes the initialization of the Logstash service's URI in the logstash/node_stats metricset.

Why is it important?

Prior to this fix, when the logstash-xpack Metricbeat module was enabled, users would need to start up Metricbeat after Logstash was started up in order for the logstash/node_stats metricset to report the correct data.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@ycombinator ycombinator added bug needs_backport PR is waiting to be backported to other branches. Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team v7.6.3 v7.7.0 v7.8.0 v8.0.0 labels Apr 4, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@ycombinator
Copy link
Contributor Author

CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit ded1ccc into elastic:master Apr 7, 2020
@ycombinator ycombinator deleted the mb-ls-xp-init-bugfix branch April 7, 2020 18:02
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Apr 7, 2020
ycombinator added a commit that referenced this pull request Apr 8, 2020
* Fix initialization of Logstash service URL

* Adding CHANGELOG entry

* Expose Logstash HTTP API port in local environment

* Remove once field as it is no longer used

* Encapsulating more logic into method

* Debugging

* Compare cluster UUIDs

* Adding ES service

* Adding default LS pipeline that outputs to ES cluster

* Use beats input so LS pipeline (and node) keeps running

* Fixing up ES config in docker compose file

* Handle errors

* Fixing typo

* COPY pipeline file as part of image

* Refactoring code to make testable + Adding unit tests

* Adding comment for test

* Fixing URIs
ycombinator added a commit that referenced this pull request Apr 8, 2020
* Fix initialization of Logstash service URL

* Adding CHANGELOG entry

* Expose Logstash HTTP API port in local environment

* Remove once field as it is no longer used

* Encapsulating more logic into method

* Debugging

* Compare cluster UUIDs

* Adding ES service

* Adding default LS pipeline that outputs to ES cluster

* Use beats input so LS pipeline (and node) keeps running

* Fixing up ES config in docker compose file

* Handle errors

* Fixing typo

* COPY pipeline file as part of image

* Refactoring code to make testable + Adding unit tests

* Adding comment for test

* Fixing URIs
ycombinator added a commit that referenced this pull request Apr 9, 2020
* Fix initialization of Logstash service URL (#17497)

* Fix initialization of Logstash service URL

* Adding CHANGELOG entry

* Expose Logstash HTTP API port in local environment

* Remove once field as it is no longer used

* Encapsulating more logic into method

* Debugging

* Compare cluster UUIDs

* Adding ES service

* Adding default LS pipeline that outputs to ES cluster

* Use beats input so LS pipeline (and node) keeps running

* Fixing up ES config in docker compose file

* Handle errors

* Fixing typo

* COPY pipeline file as part of image

* Refactoring code to make testable + Adding unit tests

* Adding comment for test

* Fixing URIs

* CHANGELOG grooming

* Removing assert
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…7592)

* Fix initialization of Logstash service URL

* Adding CHANGELOG entry

* Expose Logstash HTTP API port in local environment

* Remove once field as it is no longer used

* Encapsulating more logic into method

* Debugging

* Compare cluster UUIDs

* Adding ES service

* Adding default LS pipeline that outputs to ES cluster

* Use beats input so LS pipeline (and node) keeps running

* Fixing up ES config in docker compose file

* Handle errors

* Fixing typo

* COPY pipeline file as part of image

* Refactoring code to make testable + Adding unit tests

* Adding comment for test

* Fixing URIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logstash monitoring data collection requires Metricbeat to be started after Logstash
5 participants