Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19722 to 7.x: Unroll on unauthorised #19888

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #19722 to 7.x branch. Original message:

What does this PR do?

Followup to #19507
This PR detects invalid API token error coming from fleet and after 6 times of retries with backoff in row (should take 5 minutes or so to avoid transient issues). On succ request counter is zeroed.

When unroll is detected (and not coming from fleet) it is not acked but stored in action_store. Removing action store manually will enable agent to ping fleet again. Otherwise it detects it's unrolled on start and prevent talking to fleet

Why is it important?

When API is revoked agent is not notified about this and starts seeing errors. Agent does not know how to handle that and tries to kick fleet periodically

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 14, 2020
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit c6d44a1 into elastic:7.x Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport enhancement Ingest Management:beta1 Group issues for ingest management beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants