Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20469 to 7.x: Fix cisco asa/ftd parsing of msgs 106102/106103 #20493

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Aug 7, 2020

Cherry-pick of PR #20469 to 7.x branch. Original message:

What does this PR do?

Updates the parsers for messages 106102 and 106103 in the shared Cisco asa/ftd pipeline.

Why is it important?

The documentation on messages 106102 and 106103 didn't match the actual format used by devices. This is causing errors when trying to ingest those messages.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Logs

The error this fixes:

(status=400): {
    "type":"mapper_parsing_exception",
    "reason":"failed to parse field [destination.port] of type [long] in document with id '4lFGv3MBi145cg_j1NOE'. Preview of field's value: 'hit-cnt'",
    "caused_by":{
      "type":"illegal_argument_exception",
      "reason":"For input string: \"hit-cnt\""
    }
  }

These documentation on those messages didn't match the actual format
used by devices.

(cherry picked from commit 7ec32e4)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 7, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 7, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20493 updated]

  • Start Time: 2020-08-07T08:13:11.379+0000

  • Duration: 56 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 2434
Skipped 385
Total 2819

@adriansr adriansr merged commit d1a9947 into elastic:7.x Aug 10, 2020
@zube zube bot removed the [zube]: Done label Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants