Fix doc build issues happening in linux/memory #27381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
Is there any reason this has not been backported to 7.x? I'm seeing the same issues on my 7.x backport (docs being updated when executed on a mac, etc). |
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
* fix doc build issues * add changelog * move tests to linux-only (cherry picked from commit b906aab)
fearful-symmetry
added a commit
that referenced
this pull request
Oct 1, 2021
* fix doc build issues * add changelog * move tests to linux-only (cherry picked from commit b906aab) Co-authored-by: Alex K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes an issue reported by @faec . Because the main .go file for linux/memory had a build constraint, targets like
makeUpdatewere changing the docs on non-linux platforms. This wasn't breaking CI, but it was annoying. This shuffles around the files so we don't need the build constraints anymore.Why is it important?
This was annoying for people developing on darwin/windows.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.