Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont overwrite metadata in rds and dimension in cloudwatch #29101

Closed
wants to merge 2 commits into from
Closed

dont overwrite metadata in rds and dimension in cloudwatch #29101

wants to merge 2 commits into from

Conversation

aspacca
Copy link
Contributor

@aspacca aspacca commented Nov 23, 2021

Bug

What does this PR do?

Ensure that dimensions and rds metadata from cloudwatch metric are not overwritten

Why is it important?

It was reported a case of mismatching metadata in RDS metrics between aws.dimensions.DBInstanceIdentifier and aws.rds.db_instance.identifier

Changes in this PR will prevent to set the metadata and dimensions multiple time if they are already set for a specific event

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2021

This pull request does not have a backport label. Could you fix it @aspacca? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 23, 2021
@aspacca aspacca added Team:Platforms Label for the Integrations - Platforms team and removed backport-skip Skip notification from the automated backport with mergify labels Nov 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 23, 2021
@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Nov 23, 2021
@aspacca aspacca self-assigned this Nov 23, 2021
@aspacca aspacca added backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify labels Nov 23, 2021
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Nov 23, 2021
@elasticmachine
Copy link
Collaborator

❕ Build Aborted

There is a new build on-going so the previous on-going builds have been aborted.

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Reason: Aborted from #2

  • Start Time: 2021-11-23T13:02:08.534+0000

  • Duration: 8 min 39 sec

  • Commit: 54451ae

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@endorama
Copy link
Member

Can we add a test around this? Or shouldn't this be found out by the tests already?

@aspacca
Copy link
Contributor Author

aspacca commented Nov 23, 2021

@endorama sure, we can add a test mocking wrong metadata and assuring only the first one will be set

@aspacca
Copy link
Contributor Author

aspacca commented Nov 23, 2021

closing in favour of #29106

@aspacca aspacca closed this Nov 23, 2021
@aspacca aspacca deleted the cloudwatch-dont-overwrite-metdata branch November 23, 2021 17:15
@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants