Fix Python environment activation #29252
Conversation
andresrc
added
bug
backport-v8.0.0
botelastic
bot
added
the
needs_team
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
(cherry picked from commit 8896fd3)
(cherry picked from commit 8896fd3)
(cherry picked from commit 8896fd3) Co-authored-by: Andres Rodriguez <[email protected]>
(cherry picked from commit 8896fd3) Co-authored-by: Andres Rodriguez <[email protected]>
| @@ -128,8 +128,9 @@ check-no-changes: | |||
| ## check-python : Python Linting. | |||
| .PHONY: check-python | |||
| check-python: python-env | |||
| @$(FIND) -name *.py -name *.py -not -path "*/build/*" -exec $(PYTHON_ENV)/bin/autopep8 -d --max-line-length 120 {} \; | (! grep . -q) || (echo "Code differs from autopep8's style" && false) | |||
| @$(FIND) -name *.py -not -path "*/build/*" | xargs $(PYTHON_ENV)/bin/pylint --py3k -E || (echo "Code is not compatible with Python 3" && false) | |||
| @. $(PYTHON_ENV)/bin/activate; \ | |||
There was a problem hiding this comment.
Interesting that this is needed here, commands are executed with the full path under the venv.
There was a problem hiding this comment.
I wonder if it would be worth to "reasses" these lines as it seems there wer some challenges around it recently.
What does this PR do?
Fixes python environment activation. The fix is being tested as part of #29245 , where the issue was detected. This PR is to isolate the fix in an independent change.
Why is it important?
In #29245 builds have started failing. It seems that some change in the workers have make this issue surface.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
To be tested with a CI build.
Related issues
Use cases
Screenshots
Logs