Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #30668) libbeat: Don't force an ignore_above limit on wildcard fields #30707

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 7, 2022

This is an automatic backport of pull request #30668 done by Mergify.
Cherry-pick of 677229f has failed:

On branch mergify/bp/7.17/pr-30668
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit 677229fa34.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG-developer.next.asciidoc
	modified:   CHANGELOG.next.asciidoc
	modified:   libbeat/template/processor.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   libbeat/template/processor_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Mar 7, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 7, 2022
@botelastic
Copy link

botelastic bot commented Mar 7, 2022

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Contributor Author

mergify bot commented Mar 7, 2022

This pull request has not been merged yet. Could you please review and merge it @adriansr? 🙏

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 7, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview [preview](https://ci-stats.elastic.co/app/apm/services/beats-ci/transactions/view?rangeFrom=2022-03-07T17:07:34.721Z&rangeTo=2022-03-07T17:27:34.721Z&transactionName=BUILD Beats/beats/PR-{number}&transactionType=job&latencyAggregationType=avg&traceId=e6234701eda4cbac2210ecc97cd74969&transactionId=5cfcd5be7998364f)

Expand to view the summary

Build stats

  • Start Time: 2022-03-07T17:17:34.721+0000

  • Duration: 103 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 55414
Skipped 5359
Total 60773

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Modifies libbeat's template processor to stop hardcoding a default
`ignore_above` limit of 1024 on wildcard fields. This behavior was
inherited from keyword fields.

Closes #30096

(cherry picked from commit 677229f)
@mergify
Copy link
Contributor Author

mergify bot commented Mar 14, 2022

This pull request has not been merged yet. Could you please review and merge it @adriansr? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Mar 14, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/7.17/pr-30668 upstream/mergify/bp/7.17/pr-30668
git merge upstream/7.17
git push upstream mergify/bp/7.17/pr-30668

@adriansr adriansr closed this Mar 14, 2022
@mergify mergify bot deleted the mergify/bp/7.17/pr-30668 branch March 14, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants