ci: enable windows for testing heartbeat #32937

v1v · 2022-08-31T14:15:56Z

What does this PR do?

Enable testing for heartbeat on windows.

Why is it important?

It was disabled since some tests were failing, and reported those tests but no further actions were done.

Let's enable back so the @elastic/uptime can figure out what's going on

elasticmachine · 2022-08-31T14:24:32Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-08-31T20:44:53.105+0000
Duration: 53 min 40 sec

Test stats 🧪

Test	Results
Failed	0
Passed	178
Skipped	0
Total	178

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

None of this is supported or works there, so we should just disable it. Fixes elastic#32937 No release notes necessary since there are no user facing changes

…2939) None of this is supported or works there, so we should just disable it. Fixes elastic#32937 No release notes necessary since there are no user facing changes

v1v · 2022-08-31T19:51:31Z

/test

andrewvc · 2022-08-31T20:17:02Z

Apologies, I missed some build tags, mind if I push them directly here to make testing them easier?

v1v · 2022-08-31T20:21:13Z

Yes, please, contribute to this PR if needed 👍

…ts' into fix-remaining-win-issues

andrewvc · 2022-08-31T20:23:04Z

I hope you don't mind @v1v , I've pushed directly to here to see if I can resolve the test failures with a few more build tags

andrewvc

LGTM

andrewvc

Well, that was premature, I thought I'd seen them all passing

…st that will come back in an improved form in elastic#30632

andrewvc · 2022-08-31T20:44:59Z

x-pack/heartbeat/scenarios/scenarios.go

@@ -70,30 +69,5 @@ var Scenarios = &ScenarioDB{
 }, func() {}, nil
 },
 },
- {
- Name: "simple-browser",


Temporarily remove browser test from scenarios. This is a very new test that will come
back in an improved form in #30632

andrewvc

LGTM now

v1v · 2022-09-01T08:22:58Z

I can see some errors in the logs:

[2022-08-31T21:06:34.702Z] >> python test: Unit Testing
[2022-08-31T21:06:59.250Z] ERROR: Could not install packages due to an EnvironmentError: [WinError 5] Access is denied: 'C:\\Users\\jenkins\\AppData\\Local\\Temp\\pip-uninstall-deorbl2h\\pip.exe'
[2022-08-31T21:06:59.250Z] Consider using the `--user` option or check the permissions.
[2022-08-31T21:06:59.250Z] 
[2022-08-31T21:07:40.233Z] warn: failed to upgrade pip (ignoring): running "null\build\ve\windows\Scripts\pip install -U pip" failed with exit code 1>> python test: Unit Testing - No tests found.

https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats%2FPR-32937/detail/PR-32937/6/pipeline/1446#step-2249-log-15

I just compared with a different build for a different component and similar outcome but in this case it ran some python tests

[2022-08-31T21:42:09.207Z] >> go test: Unit Test Passed
[2022-08-31T21:42:10.580Z] Generated fields.yml for metricbeat to C:\Users\jenkins\workspace\PR-32943-2-f1330a12-3ea8-4829-b203-948c9932e0d3\src\github.com\elastic\beats\x-pack\metricbeat\fields.yml
[2022-08-31T21:42:37.791Z] >> python test: Unit Testing
[2022-08-31T21:43:01.651Z] ERROR: Could not install packages due to an EnvironmentError: [WinError 5] Access is denied: 'C:\\Users\\jenkins\\AppData\\Local\\Temp\\pip-uninstall-bdd6i7kv\\pip.exe'
[2022-08-31T21:43:01.651Z] Consider using the `--user` option or check the permissions.
[2022-08-31T21:43:01.651Z] 
[2022-08-31T21:43:43.877Z] warn: failed to upgrade pip (ignoring): running "null\build\ve\windows\Scripts\pip install -U pip" failed with exit code 1============================= test session starts =============================
[2022-08-31T21:43:43.878Z] platform win32 -- Python 3.8.5, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
[2022-08-31T21:43:43.878Z] rootdir: C:\Users\jenkins\workspace\PR-32943-2-f1330a12-3ea8-4829-b203-948c9932e0d3\src\github.com\elastic\beats, configfile: pytest.ini
[2022-08-31T21:43:43.878Z] plugins: otel-1.1.1, rerunfailures-9.1.1, timeout-1.4.2
[2022-08-31T21:43:43.878Z] timeout: 90.0s
[2022-08-31T21:43:43.878Z] timeout method: thread
[2022-08-31T21:43:43.878Z] timeout func_only: True
[2022-08-31T21:43:43.878Z] collected 29 items
[2022-08-31T21:43:43.878Z] 
[2022-08-31T21:43:55.452Z] tests\system\test_xpack_base.py s.....s.                                 [ 27%]

https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats%2FPR-32937/detail/PR-32937/6/pipeline/1446#step-2249-log-15

I don't know if those errors are genuine or flaky... and what's the reason the mage test does not fail, any hints?

v1v · 2022-09-01T15:15:58Z

@andrewvc , what's your feedback for #32937 (comment) ? It's the expected behaviour?

andrewvc · 2022-09-01T15:47:12Z

@v1v that's a bit of a mystery to me TBH, we don't do any python stuff outside of the standard tasks defined in libbeat's mage helpers.

I would have assumed that error would be present for all beats on windows if it's present for us. Are you certain other beats are running mage pythonUnitTest on windows?

Running locally on my win box (which I never normally do) I get a different, but similar error on metricbeat and heartbeat:

[notice] To update, run: C:\Users\AndrewCholakian\projects\beats\build\ve\windows\Scripts\python.exe -m pip install --upgrade pip
                                                                                         cd^C
C:\Users\AndrewCholakian\projects\beats\heartbeat [fix-remaining-win-issues +3 ~0 -0 !]> ^C
C:\Users\AndrewCholakian\projects\beats\heartbeat [fix-remaining-win-issues +3 ~0 -0 !]>
C:\Users\AndrewCholakian\projects\beats\heartbeat [fix-remaining-win-issues +3 ~0 -0 !]>
C:\Users\AndrewCholakian\projects\beats\heartbeat [fix-remaining-win-issues +3 ~0 -0 !]> cd ..\metricbeat
C:\Users\AndrewCholakian\projects\beats\metricbeat [fix-remaining-win-issues +3 ~0 -0 !]> mage pythonUnitTest
Generated fields.yml for metricbeat to C:\Users\AndrewCholakian\projects\beats\metricbeat\fields.yml
Generated fields.yml for metricbeat to C:\Users\AndrewCholakian\projects\beats\metricbeat\fields.yml
>> python test: Unit Testing
ERROR: To modify pip, please run the following command:
C:\Users\AndrewCholakian\projects\beats\build\ve\windows\Scripts\python.exe -m pip install -U pip

[notice] A new release of pip available: 22.2.1 -> 22.2.2
[notice] To update, run: C:\Users\AndrewCholakian\projects\beats\build\ve\windows\Scripts\python.exe -m pip install --upgrade pip
warn: failed to upgrade pip (ignoring): running "C:\Users\AndrewCholakian\projects\beats\build\ve\windows\Scripts\pip install -U pip" failed with exit code 1
[notice] A new release of pip available: 22.2.1 -> 22.2.2
[notice] To update, run: C:\Users\AndrewCholakian\projects\beats\build\ve\windows\Scripts\python.exe -m pip install --upgrade pip
ERROR: Could not find a version that satisfies the requirement pywin32==227; sys_platform == "win32" (from docker) (from versions: 302, 303, 304)
ERROR: No matching distribution found for pywin32==227; sys_platform == "win32"

[notice] A new release of pip available: 22.2.1 -> 22.2.2
[notice] To update, run: C:\Users\AndrewCholakian\projects\beats\build\ve\windows\Scripts\python.exe -m pip install --upgrade pip
Error: running "C:\Users\AndrewCholakian\projects\beats\build\ve\windows\Scripts\pip install --quiet -Ur C:\Users\AndrewCholakian\projects\beats/libbeat/tests/system/requirements.txt" failed with exit code 1

They're both running pip commands.

TBH, I would like to keep those disabled on windows, the value those tests add is minimal, not nearly high enough to justify the maintenance cost, esp. given that we've never had a windows specific bug in many years.

v1v · 2022-09-01T15:49:50Z

Are you certain other beats are running mage pythonUnitTest on windows?

Yes, with similar outcome but running some tests afterwards, for instance, https://beats-ci.elastic.co/blue/organizations/jenkins/Beats%2Fbeats%2FPR-32937/detail/PR-32937/6/pipeline/1446#step-2249-log-15 for metricbeat

I assume, since it happens for other components it's okey to merge this PR.

Do you want me to do it now?

andrewvc · 2022-09-01T15:53:26Z

Yes, ++ on merging

(cherry picked from commit 8552e34) # Conflicts: # x-pack/heartbeat/Jenkinsfile.yml # x-pack/heartbeat/monitors/browser/source/project.go # x-pack/heartbeat/monitors/browser/source/project_test.go # x-pack/heartbeat/monitors/browser/source/source.go # x-pack/heartbeat/scenarios/basics_test.go # x-pack/heartbeat/scenarios/scenarios.go

(cherry picked from commit 8552e34) # Conflicts: # x-pack/heartbeat/monitors/browser/source/source.go

This reverts commit 8552e34.

None of this is supported or works there, so we should just disable it. Fixes #32937 No release notes necessary since there are no user facing changes

ci: enable windows for testing heartbeat

c078f72

v1v added Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.4.0 Automated backport with mergify labels Aug 31, 2022

v1v requested a review from a team as a code owner August 31, 2022 14:15

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 31, 2022

mergify bot assigned v1v Aug 31, 2022

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 31, 2022

fix ident

18583d5

andrewvc mentioned this pull request Aug 31, 2022

[heartbeat] disable browser code on windows via build tags #32939

Merged

[heartbeat] disable browser code on windows via build tags (elastic#3…

86f07ed

…2939) None of this is supported or works there, so we should just disable it. Fixes elastic#32937 No release notes necessary since there are no user facing changes

andrewvc closed this in #32939 Aug 31, 2022

Update to Go 1.18 in go.mod. (elastic#32940)

8488565

v1v reopened this Aug 31, 2022

v1v and others added 3 commits August 31, 2022 20:52

action: checks for x-pack/libbeat and libbeat (elastic#32754)

d1aaef0

Fix win deps

05223ca

Restrict all browser source from win builds

ce129ee

Merge remote-tracking branch 'v1v/feature/enable-windows-for-heartbea…

00152e3

…ts' into fix-remaining-win-issues

andrewvc requested a review from a team as a code owner August 31, 2022 20:22

andrewvc requested review from belimawr and rdner and removed request for a team August 31, 2022 20:22

andrewvc approved these changes Aug 31, 2022

View reviewed changes

andrewvc requested changes Aug 31, 2022

View reviewed changes

Temporarily remove browser test from scenarios. This is a very new te…

54c1cd5

…st that will come back in an improved form in elastic#30632

andrewvc reviewed Aug 31, 2022

View reviewed changes

andrewvc approved these changes Sep 1, 2022

View reviewed changes

v1v merged commit 8552e34 into elastic:main Sep 1, 2022

mergify bot mentioned this pull request Sep 1, 2022

[7.17](backport #32937) ci: enable windows for testing heartbeat #32962

Closed

mergify bot pushed a commit that referenced this pull request Sep 1, 2022

ci: enable windows for testing heartbeat (#32937)

5962d30

(cherry picked from commit 8552e34) # Conflicts: # x-pack/heartbeat/monitors/browser/source/source.go

mergify bot mentioned this pull request Sep 1, 2022

[8.4](backport #32937) ci: enable windows for testing heartbeat #32963

Closed

andrewvc mentioned this pull request Sep 6, 2022

[Heartbeat] Pip install doesn't work on windows tests #32994

Closed

andrewvc added a commit that referenced this pull request Sep 12, 2022

Revert "ci: enable windows for testing heartbeat (#32937)"

5991aa1

This reverts commit 8552e34.

andrewvc added a commit to andrewvc/beats that referenced this pull request Sep 12, 2022

Revert "ci: enable windows for testing heartbeat (elastic#32937)"

045969b

This reverts commit 8552e34.

chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023

ci: enable windows for testing heartbeat (#32937)

9a93cd5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: enable windows for testing heartbeat #32937

ci: enable windows for testing heartbeat #32937

v1v commented Aug 31, 2022

elasticmachine commented Aug 31, 2022 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

v1v commented Aug 31, 2022

andrewvc commented Aug 31, 2022

v1v commented Aug 31, 2022

andrewvc commented Aug 31, 2022

andrewvc left a comment

andrewvc left a comment

andrewvc Aug 31, 2022

andrewvc left a comment

v1v commented Sep 1, 2022 •

edited

Loading

v1v commented Sep 1, 2022

andrewvc commented Sep 1, 2022

v1v commented Sep 1, 2022

andrewvc commented Sep 1, 2022

ci: enable windows for testing heartbeat #32937

ci: enable windows for testing heartbeat #32937

Conversation

v1v commented Aug 31, 2022

What does this PR do?

Why is it important?

elasticmachine commented Aug 31, 2022 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

v1v commented Aug 31, 2022

andrewvc commented Aug 31, 2022

v1v commented Aug 31, 2022

andrewvc commented Aug 31, 2022

andrewvc left a comment

Choose a reason for hiding this comment

andrewvc left a comment

Choose a reason for hiding this comment

andrewvc Aug 31, 2022

Choose a reason for hiding this comment

andrewvc left a comment

Choose a reason for hiding this comment

v1v commented Sep 1, 2022 • edited Loading

v1v commented Sep 1, 2022

andrewvc commented Sep 1, 2022

v1v commented Sep 1, 2022

andrewvc commented Sep 1, 2022

elasticmachine commented Aug 31, 2022 •

edited by jenkins-beats-ci bot

Loading

v1v commented Sep 1, 2022 •

edited

Loading