Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix make clean (#34134) #34141

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

AndersonQ
Copy link
Member

This is a forwardport of #34134

What does this PR do?

Fixes make clean

Why is it important?

make clean was failing, thus not cleaning the project what might lead to an old build of the beats being used when the elastic-agent package process looks for local beats packages.

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run make clean, it must succeed

Related issues

N/A

- when cleaning the project it ignore 'permission denied' errors
- remove broken make call
@AndersonQ AndersonQ requested a review from a team as a code owner December 29, 2022 07:50
@AndersonQ AndersonQ requested review from cmacknz and fearful-symmetry and removed request for a team December 29, 2022 07:50
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 29, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @AndersonQ? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@AndersonQ AndersonQ added the Team:Elastic-Agent Label for the Agent team label Dec 29, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 29, 2022
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-29T07:51:14.542+0000

  • Duration: 81 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 25155
Skipped 1954
Total 27109

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@michalpristas michalpristas merged commit acd70e9 into elastic:main Dec 29, 2022
@AndersonQ AndersonQ deleted the forwardport-fix-make-clean branch December 29, 2022 18:05
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
- when cleaning the project it ignore 'permission denied' errors
- remove broken make call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants