Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop re-using processors defined in the config #34761

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Stop re-using processors defined in the config #34761

merged 3 commits into from
Mar 7, 2023

Commits on Mar 7, 2023

  1. Stop re-using processors defined in the config 

    After introducing the `SafeProcessor` wrapper in
elastic#34647 we started returning
errors when a processor is being used after its `Close` function has
been called.

This led to dropped events and error spam in logs but also confirmed
that the root cause of the problem was not just a race condition on
`Close` but re-used processors somewhere.

After a long investigation such code that's re-using processors was
finally found.

This is the change that removes re-using the processors and
instantiates them on each input restart.
    @rdner
    rdner committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    59dbbb0 View commit details
    Browse the repository at this point in the history

  2. Fix linter issues

    @rdner
    rdner committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    c90f3de View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @rdner
    rdner committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    ce675d5 View commit details
    Browse the repository at this point in the history