all: remove the repetitive word "the" #35975

cuishuang · 2023-06-30T07:49:22Z

What does this PR do?

To ensure grammatical correctness, it is recommended to remove repetitive instances of the word "the" in sentences.

Why is it important?

Fixes grammatical errors.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Signed-off-by: cui fliter <[email protected]>

botelastic · 2023-06-30T07:49:29Z

This pull request doesn't have a Team:<team> label.

mergify · 2023-06-30T07:50:05Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @cuishuang? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2023-06-30T07:54:13Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-08-29T15:01:10.195+0000
Duration: 130 min 51 sec

Test stats 🧪

Test	Results
Failed	0
Passed	27766
Skipped	1978
Total	29744

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2023-08-14T08:54:42Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b main upstream/main
git merge upstream/main
git push upstream main

Signed-off-by: cui fliter <[email protected]>

cuishuang · 2023-08-14T09:46:24Z

Done. Please review again.

shmsr · 2023-08-14T13:46:33Z

@cuishuang Can you please run make check followed by make update and commit and push those changes as well?

cuishuang · 2023-08-15T02:36:58Z

@cuishuang Can you please run make check followed by make update and commit and push those changes as well?

Hello, I executed make check but reported the following error

cgo-gcc-prolog:452:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here Error: some files are not up-to-date. Run 'make update' then review and commit the changes. Modified: [auditbeat/include/fields.go] make[1]: *** [check] Error 1 make: *** [check] Error 1

shmsr · 2023-08-15T11:12:51Z

@cuishuang Can you please run make check followed by make update and commit and push those changes as well?

Hello, I executed make check but reported the following error

cgo-gcc-prolog:452:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here Error: some files are not up-to-date. Run 'make update' then review and commit the changes. Modified: [auditbeat/include/fields.go] make[1]: *** [check] Error 1 make: *** [check] Error 1

Yeah, run make update.

Signed-off-by: cui fliter <[email protected]>

cuishuang · 2023-08-15T14:17:16Z

@cuishuang Can you please run make check followed by make update and commit and push those changes as well?

Hello, I executed make check but reported the following error
cgo-gcc-prolog:452:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations] /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here Error: some files are not up-to-date. Run 'make update' then review and commit the changes. Modified: [auditbeat/include/fields.go] make[1]: *** [check] Error 1 make: *** [check] Error 1

Yeah, run make update.

Done. Please review again.

cuishuang · 2023-08-23T09:55:08Z

friendly ping~

shmsr · 2023-08-25T10:43:03Z

@cuishuang Can you check why golangci-lint is failing? Otherwise, changes look good to me.

cuishuang · 2023-08-26T09:13:16Z

@cuishuang Can you check why golangci-lint is failing? Otherwise, changes look good to me.

I checked the relevant error reports and got the reason: golangci-lint in the workflow will detect the files that have been modified this time. I changed winlogbeat/sys/winevent/event_test.go, this file contains a piece of information in Spanish, and the variable mensajeEnEspañol contains non-ascii characters (Español means Spanish); in addition, comando in the text is considered to be misspelled (It's not wrong actually, it means "command" in Spanish).

I guess golangci-lint may have been added after this information, so there was no error message at that time. I think it can be ignored

mergify · 2023-08-31T21:01:07Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b main upstream/main
git merge upstream/main
git push upstream main

Signed-off-by: cui fliter <[email protected]>

shmsr · 2023-09-08T11:52:39Z

filebeat/include/fields.go

@@ -32,5 +32,5 @@ func init() {
 // AssetFieldsYml returns asset data.
 // This is the base64 encoded zlib format compressed contents of fields.yml.
 func AssetFieldsYml() string {


Hey. Why *.go files are touched? I see some more files are modified and in some unexpected parts.

shmsr · 2023-09-08T11:52:55Z

heartbeat/include/fields.go

@@ -1,36 +0,0 @@
-// Licensed to Elasticsearch B.V. under one or more contributor


why full file removed?

shmsr · 2023-09-08T11:53:42Z

x-pack/osquerybeat/include/fields.go

@@ -19,5 +19,5 @@ func init() {
 // AssetFieldsYml returns asset data.
 // This is the base64 encoded zlib format compressed contents of fields.yml.
 func AssetFieldsYml() string {


This is also not right. Read my first comment.

I feel like too much time has been spent and this submission is of little value.

Feel sorry, I hope other developers can submit a new PR based on this.

all: remove repetitive the

9e96e92

Signed-off-by: cui fliter <[email protected]>

cuishuang requested review from a team as code owners June 30, 2023 07:49

cuishuang requested review from ycombinator and fearful-symmetry June 30, 2023 07:49

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 30, 2023

mergify bot assigned cuishuang Jun 30, 2023

all: remove repetitive the

cc1e8f4

Signed-off-by: cui fliter <[email protected]>

all: remove repetitive the

5d60bd4

Signed-off-by: cui fliter <[email protected]>

shmsr approved these changes Aug 26, 2023

View reviewed changes

shmsr changed the title ~~all: remove repetitive the~~ all: remove the repetitive word "the" Aug 26, 2023

Merge branch 'main' into main

d59728c

all: remove the repetitive word the

0371e99

Signed-off-by: cui fliter <[email protected]>

cuishuang closed this Sep 1, 2023

shmsr self-requested a review September 8, 2023 11:48

shmsr reviewed Sep 8, 2023

View reviewed changes

shmsr self-requested a review September 8, 2023 11:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

all: remove the repetitive word "the" #35975

all: remove the repetitive word "the" #35975

cuishuang commented Jun 30, 2023 •

edited by shmsr

Loading

botelastic bot commented Jun 30, 2023

mergify bot commented Jun 30, 2023

elasticmachine commented Jun 30, 2023 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

mergify bot commented Aug 14, 2023

cuishuang commented Aug 14, 2023

shmsr commented Aug 14, 2023

cuishuang commented Aug 15, 2023

shmsr commented Aug 15, 2023

cuishuang commented Aug 15, 2023

cuishuang commented Aug 23, 2023

shmsr commented Aug 25, 2023

cuishuang commented Aug 26, 2023

mergify bot commented Aug 31, 2023

shmsr Sep 8, 2023 •

edited

Loading

shmsr Sep 8, 2023

shmsr Sep 8, 2023

cuishuang Sep 8, 2023

		@@ -1,36 +0,0 @@
		// Licensed to Elasticsearch B.V. under one or more contributor

all: remove the repetitive word "the" #35975

all: remove the repetitive word "the" #35975

Conversation

cuishuang commented Jun 30, 2023 • edited by shmsr Loading

What does this PR do?

Why is it important?

Checklist

botelastic bot commented Jun 30, 2023

mergify bot commented Jun 30, 2023

elasticmachine commented Jun 30, 2023 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

mergify bot commented Aug 14, 2023

cuishuang commented Aug 14, 2023

shmsr commented Aug 14, 2023

cuishuang commented Aug 15, 2023

shmsr commented Aug 15, 2023

cuishuang commented Aug 15, 2023

cuishuang commented Aug 23, 2023

shmsr commented Aug 25, 2023

cuishuang commented Aug 26, 2023

mergify bot commented Aug 31, 2023

shmsr Sep 8, 2023 • edited Loading

Choose a reason for hiding this comment

shmsr Sep 8, 2023

Choose a reason for hiding this comment

shmsr Sep 8, 2023

Choose a reason for hiding this comment

cuishuang Sep 8, 2023

Choose a reason for hiding this comment

cuishuang commented Jun 30, 2023 •

edited by shmsr

Loading

elasticmachine commented Jun 30, 2023 •

edited by jenkins-beats-ci bot

Loading

shmsr Sep 8, 2023 •

edited

Loading