Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/awss3 ; Fix nil hit panic when a getter is invoked on input metric #36101

Merged
merged 13 commits into from
Jul 24, 2023

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Jul 18, 2023

What does this PR do?

This PR fixes the panic mentioned in #36077. If an input metrics is not initialised but when a Get is invoked on the metric to pull data , then a nil pointer panic is caused.

Why is it important?

To avoid nil pointer panics when metric getters are invoked

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Without this PR , when go test -tags aws,integration -run TestInputRunSQS -v is run from x-pack/filebeat/input/awss3 then a nil pointer panic is caused and this PR fixes it.

Related issues

@bhapas bhapas self-assigned this Jul 18, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 18, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 18, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @bhapas? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@bhapas bhapas marked this pull request as ready for review July 18, 2023 14:12
@bhapas bhapas requested a review from a team as a code owner July 18, 2023 14:12
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@bhapas
Copy link
Contributor Author

bhapas commented Jul 18, 2023

Pinging @elastic/obs-cloud-monitoring as a codeowner

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-24T13:27:58.192+0000

  • Duration: 135 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 6159
Skipped 357
Total 6516

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@bhapas bhapas requested a review from andrewkroh July 18, 2023 18:28
@bhapas bhapas added the backport-v8.9.0 Automated backport with mergify label Jul 18, 2023
@bhapas bhapas added the Filebeat Filebeat label Jul 19, 2023
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I'd like to get @andrewkroh 's approval on this before merging. Thanks!

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b fix-commented-aws-tests upstream/fix-commented-aws-tests
git merge upstream/main
git push upstream fix-commented-aws-tests

@bhapas bhapas requested a review from andrewkroh July 24, 2023 06:48
x-pack/filebeat/input/awss3/input.go Outdated Show resolved Hide resolved
@bhapas bhapas merged commit cc740f9 into elastic:main Jul 24, 2023
8 checks passed
mergify bot pushed a commit that referenced this pull request Jul 24, 2023
bhapas added a commit that referenced this pull request Jul 25, 2023
…ked on input metric (#36101) (#36145)

(cherry picked from commit cc740f9)

Co-authored-by: Bharat Pasupula <[email protected]>
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.9.0 Automated backport with mergify bugfix Filebeat Filebeat Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[filebeat][awss3][automation] Panic in integration test while polling input metrics for SQS
4 participants