Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14](backport #39134) [Auditbeat] Remove temporary "ReplaceFields" config option #39168

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 23, 2024

Proposed commit message

Remove the "ReplaceFields" config option from the 'add_session_metadata' processor in Auditbeat. This was always intended to be a temporary config option, that allowed use of the Kibana session viewer, before the Kibana feature was fully developed.

The Kibana changes are now done, so this processor option is no longer needed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc. This was developer only option, on a feature that's not GA, so I don't think it needs a changelog entry

Related issues


This is an automatic backport of pull request #39134 done by [Mergify](https://mergify.com).

The ReplaceFields config option was used to support compatibility with session
viewer in Kibana that didn't support auditbeat fields. Kibana has now been
updated, and this config option isn't needed.

(cherry picked from commit b34334f)
@mergify mergify bot added the backport label Apr 23, 2024
@mergify mergify bot requested a review from a team as a code owner April 23, 2024 19:58
@mergify mergify bot assigned mjwolf Apr 23, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 23, 2024
@botelastic
Copy link

botelastic bot commented Apr 23, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-23T19:58:48.348+0000

  • Duration: 57 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 467
Skipped 60
Total 527

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mjwolf mjwolf merged commit 11357af into 8.14 Apr 23, 2024
26 checks passed
@mjwolf mjwolf deleted the mergify/bp/8.14/pr-39134 branch April 23, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants