Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate xdg/scram usage to xdg-go/scram #39836

Merged
merged 13 commits into from
Jun 19, 2024

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Jun 8, 2024

Proposed commit message

From the repo readme:

DON'T USE THIS PACKAGE - use xdg-go/scram instead!

I renamed this to xdg-go/scram in October 2018. This didn't break dependencies at the time because Github redirected requests. In March 2021, I made xdg-go/scram a module, which can't be used as xdg/scram with Github redirects. This repository has been recreated to support legacy dependencies.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

From the repo readme:

DON'T USE THIS PACKAGE - use xdg-go/scram instead!

I renamed this to xdg-go/scram in October 2018. This didn't break dependencies at the time because Github
redirected requests. In March 2021, I made xdg-go/scram a module, which can't be used as xdg/scram with
Github redirects. This repository has been recreated to support legacy dependencies.
@kruskall kruskall requested review from a team as code owners June 8, 2024 20:54
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 8, 2024
Copy link
Contributor

mergify bot commented Jun 8, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kruskall? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 10, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 10, 2024
@pierrehilbert pierrehilbert requested a review from faec June 10, 2024 07:24
go.mod Outdated Show resolved Hide resolved
@kruskall kruskall requested a review from AndersonQ June 12, 2024 10:18
@kruskall kruskall enabled auto-merge (squash) June 19, 2024 14:43
@kruskall
Copy link
Member Author

run docs-build

@kruskall kruskall merged commit 1326875 into elastic:main Jun 19, 2024
121 checks passed
@kruskall kruskall deleted the refactor/xdg-go branch June 19, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants