Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot: fix cloud providers' SDK dependencies #40125

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

zmoog
Copy link
Contributor

@zmoog zmoog commented Jul 5, 2024

Proposed commit message

Fix Dependabot config for cloud providers' SDK dependencies.

After visiting https:/elastic/beats/network/updates, I noted the following message:

CleanShot 2024-07-05 at 19 16 41@2x

Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'

In our use case, the two package-ecosystem: gomod definitions have the same values:

  package-ecosystem: gomod
  directory: /
  target-branch: <default value>

We can't have two package-ecosystem: gomod definitions for the same directory.

So, I guess we must merge the CSP SDK definition into the existing one.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

After visiting https:/elastic/beats/network/updates, I
noted the following message:

> Update configs must have a unique combination of 'package-ecosystem', 'directory', and 'target-branch'

In our use case, the two `package-ecosystem: gomod` definitions have
the same values:

  package-ecosystem: gomod
  directory: /
  target-branch: <default value>

So, I guess we must use only one definition.
@zmoog zmoog added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Jul 5, 2024
@zmoog zmoog self-assigned this Jul 5, 2024
@zmoog zmoog changed the title Fix cloud providers' SDK dependencies Dependabot: fix cloud providers' SDK dependencies Jul 5, 2024
@zmoog zmoog marked this pull request as ready for review July 5, 2024 17:26
@zmoog zmoog requested a review from a team as a code owner July 5, 2024 17:26
Copy link
Contributor

mergify bot commented Jul 5, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @zmoog? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 5, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From platform-ingest eng-prod PoV LGTM

.github/dependabot.yml Outdated Show resolved Hide resolved
Co-authored-by: Dimitrios Liappis <[email protected]>
@zmoog zmoog enabled auto-merge (squash) July 8, 2024 15:02
@zmoog zmoog merged commit e59a23e into main Jul 8, 2024
10 checks passed
@zmoog zmoog deleted the zmoog/fix-dependabot-config-for-csp-sdks branch July 8, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants