[syslog] Fix handling of escaped characters in structured data #40446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improved parser to handle escaped closing square brackets in structured data. - Fix incorrect offset being passed to removeBytes function, which would not remove escaped characters from structured data values. - Add tests
taylor-swanson
added
bug
libbeat
Team:Security-Deployment and Devices
botelastic
bot
added
needs_team
|
This pull request doesn't have a |
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
|
/test |
aleksmaus
approved these changes
Aug 7, 2024
|
Moving back to draft, as another edge case was found with structured data parsing. |
- The non-compliant-sd cases now include escapes on the closing brackets within the structured data, something that should have always been there.
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
- Improved parser to handle escaped closing square brackets in structured data, along with square brackets in the normal, non-structured data portion of the message. - Fix incorrect offset being passed to removeBytes function, which would not remove escaped characters from structured data values. - The non-compliant-sd unit test cases now include escapes on the closing brackets within the structured data, something that should have always been there. - Add tests (cherry picked from commit 1c01d0e)
Merged
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
- Improved parser to handle escaped closing square brackets in structured data, along with square brackets in the normal, non-structured data portion of the message. - Fix incorrect offset being passed to removeBytes function, which would not remove escaped characters from structured data values. - The non-compliant-sd unit test cases now include escapes on the closing brackets within the structured data, something that should have always been there. - Add tests (cherry picked from commit 1c01d0e)
Merged
3 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Aug 12, 2024
…n structured data (#40463) * [syslog] Fix handling of escaped characters in structured data (#40446) - Improved parser to handle escaped closing square brackets in structured data, along with square brackets in the normal, non-structured data portion of the message. - Fix incorrect offset being passed to removeBytes function, which would not remove escaped characters from structured data values. - The non-compliant-sd unit test cases now include escapes on the closing brackets within the structured data, something that should have always been there. - Add tests (cherry picked from commit 1c01d0e) * fix up changelog --------- Co-authored-by: Taylor Swanson <[email protected]> Co-authored-by: Taylor Swanson <[email protected]>
taylor-swanson
added a commit
that referenced
this pull request
Aug 30, 2024
…n structured data (#40464) - Improved parser to handle escaped closing square brackets in structured data, along with square brackets in the normal, non-structured data portion of the message. - Fix incorrect offset being passed to removeBytes function, which would not remove escaped characters from structured data values. - The non-compliant-sd unit test cases now include escapes on the closing brackets within the structured data, something that should have always been there. - Add tests (cherry picked from commit 1c01d0e) --------- Co-authored-by: Taylor Swanson <[email protected]> Co-authored-by: Taylor Swanson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
N/A
How to test this PR locally
Run unit tests in libbeat/reader/syslog
Related issues