Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14](backport #40267) x-pack/filebeat/i.../entitya.../.../okta: Avoid a negative request rate #40459

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 8, 2024

Proposed commit message

x-pack/filebeat/i.../entitya.../.../okta: Avoid a negative request rate (#)

This is the minimal change necessary to fix the following problem.

Around the time of a rate limit reset, if current time is after the
reset time returned in response headers, the rate limiting code will
set a negative target rate, and if that's done at a time when no
request budget has accumulated, it will not recover and will wait
forever.

The issue linked below lists other fixes and improvements that could be made the the Okta entity analytics rate limiting code. This PR is a version that should go into the next release to relieve the impact if the other changes aren't ready yet.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues


This is an automatic backport of pull request #40267 done by [Mergify](https://mergify.com).

…te (#40267)

This is the minimal change necessary to fix the following problem.

Around the time of a rate limit reset, if current time is after the
reset time returned in response headers, the rate limiting code will
set a negative target rate, and if that's done at a time when no
request budget has accumulated, it will not recover and will wait
forever.

(cherry picked from commit 5087dd4)
@mergify mergify bot requested a review from a team as a code owner August 8, 2024 11:08
@mergify mergify bot added the backport label Aug 8, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 8, 2024
Remove unrelated changelog entry
@chrisberkhout chrisberkhout added the Team:Security-Service Integrations Security Service Integrations Team label Aug 8, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 8, 2024
@chrisberkhout chrisberkhout enabled auto-merge (squash) August 8, 2024 11:54
@chrisberkhout chrisberkhout merged commit fada072 into 8.14 Aug 8, 2024
17 of 19 checks passed
@chrisberkhout chrisberkhout deleted the mergify/bp/8.14/pr-40267 branch August 8, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants