Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat] Document winlog input and make config on par with winlogbeat #40462

Merged
merged 11 commits into from
Aug 28, 2024

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Aug 8, 2024

Proposed commit message

  • Document the winlog input

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Related issues

@marc-gr marc-gr added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify Team:Security-Windows Platform Windows Platform Team in Security Solution labels Aug 8, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 8, 2024
@mergify mergify bot assigned marc-gr Aug 8, 2024
@marc-gr marc-gr marked this pull request as ready for review August 8, 2024 13:45
@marc-gr marc-gr requested a review from a team as a code owner August 8, 2024 13:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@marc-gr
Copy link
Contributor Author

marc-gr commented Aug 27, 2024

Made the suggested change cc @andrewkroh

Copy link
Contributor

mergify bot commented Aug 28, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/document-winlog-input upstream/feat/document-winlog-input
git merge upstream/main
git push upstream feat/document-winlog-input

@marc-gr marc-gr enabled auto-merge (squash) August 28, 2024 09:35
@marc-gr marc-gr merged commit 7960af6 into main Aug 28, 2024
50 checks passed
@marc-gr marc-gr deleted the feat/document-winlog-input branch August 28, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Security-Windows Platform Windows Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants