x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph: set log max_size #40494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Filebeat
botelastic
bot
added
needs_team
… set log max_size There was no check on the tracer log settings, so the max_size was not being checked for zero. This would result in 100MB log rotation trigger and zero-sized bodies. There is no validation logic to hook this into in the config for the fetcher, so calculate it immediately before use.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
andrewkroh
reviewed
Aug 13, 2024
There was a problem hiding this comment.
I didn't trace this down, but did see there is similar code in other providers. Are those affected as well?
|
This does not affect the other providers. |
andrewkroh
approved these changes
Aug 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
… set log max_size (#40494) There was no check on the tracer log settings, so the max_size was not being checked for zero. This would result in 100MB log rotation trigger and zero-sized bodies. There is no validation logic to hook this into in the config for the fetcher, so calculate it immediately before use. (cherry picked from commit 08b5628)
6 tasks
efd6
added a commit
that referenced
this pull request
Aug 14, 2024
… set log max_size (#40494) (#40517) There was no check on the tracer log settings, so the max_size was not being checked for zero. This would result in 100MB log rotation trigger and zero-sized bodies. There is no validation logic to hook this into in the config for the fetcher, so calculate it immediately before use. (cherry picked from commit 08b5628) Co-authored-by: Dan Kortschak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
There was no check on the tracer log settings, so the max_size was not being checked for zero. This would result in 100MB log rotation trigger and zero-sized bodies. There is no validation logic to hook this into in the config for the fetcher, so calculate it immediately before use.
A fix is already included in the prospective integration change that makes use of this feature.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs