Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] add cloudformation backed guide for s3-sqs setup for filebeats #40642

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Aug 28, 2024

Proposed commit message

Improves filebeat S3 -> SQS documentation by adding a detailed guide backed by a CloudFormation template.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Fixes #40624

Screenshots

image

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 28, 2024
@Kavindu-Dodan Kavindu-Dodan added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Aug 28, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 28, 2024
@Kavindu-Dodan Kavindu-Dodan added the backport-skip Skip notification from the automated backport with mergify label Aug 28, 2024
@elastic elastic deleted a comment from mergify bot Aug 28, 2024
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template looks good to me. Should we also add a command for delete-stack?

@kaiyan-sheng kaiyan-sheng mentioned this pull request Aug 28, 2024
7 tasks
@Kavindu-Dodan
Copy link
Contributor Author

Kavindu-Dodan commented Aug 28, 2024

The template looks good to me. Should we also add a command for delete-stack?

Good point. I thought about this but didn't add that. I think the end user could continue to use the setup for their validations (ex:- programmatically upload logs or add through console to S3). A stack deletion step could confuse the user 🤔

Anyway, let me know your thoughts

@kaiyan-sheng
Copy link
Contributor

Good point. I thought about this but didn't add that. I think the end user could continue to use the setup for their validations (ex:- programmatically upload logs or add through console to S3). A stack deletion step could confuse the user 🤔

I dont have a strong opinion on this either. We can leave it out for now and change it later if we get any feedback then!

@Kavindu-Dodan
Copy link
Contributor Author

Good point. I thought about this but didn't add that. I think the end user could continue to use the setup for their validations (ex:- programmatically upload logs or add through console to S3). A stack deletion step could confuse the user 🤔

I dont have a strong opinion on this either. We can leave it out for now and change it later if we get any feedback then!

yeah, I agree. I will merge the PR with your approval :)

@Kavindu-Dodan Kavindu-Dodan merged commit 372b126 into elastic:main Aug 29, 2024
20 checks passed
@Kavindu-Dodan Kavindu-Dodan deleted the docs/filebeat-s3-sqs-doc branch August 29, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create cloudformation template to setup s3 + sqs
3 participants