refactor beats argument parsing #41277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
leehinman
added
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
pierrehilbert
added
Team:obs-ds-hosted-services
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
belimawr
reviewed
Oct 17, 2024
|
|
||
| "github.com/elastic/beats/v7/libbeat/common" | ||
| "github.com/elastic/beats/v7/libbeat/common/fleetmode" | ||
| "github.com/elastic/elastic-agent-libs/config" | ||
| "github.com/elastic/elastic-agent-libs/logp" | ||
| ) | ||
|
|
||
| // Command line flags. | ||
| // Evil package level globals |
There was a problem hiding this comment.
I love the honesty on this comment ❤️
leehinman
force-pushed
the
41153_argument_parsing
branch
from
968dbf6
to
ffcfe48
Compare
leehinman
force-pushed
the
41153_argument_parsing
branch
6 times, most recently
from
f0f6e8a
to
60b1b1c
Compare
leehinman
force-pushed
the
41153_argument_parsing
branch
2 times, most recently
from
64f67f9
to
c2f8a09
Compare
leehinman
force-pushed
the
41153_argument_parsing
branch
from
20e1daf
to
1242459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Change beats argument parsing behavior.
Beats currently sets some command line flags in an init function, this means that any other project that imports beats will have conflicts if it uses the same options. This change moves this out of init.
Beats currently modifies the Argument list to offer backwards compatibility for flags in an init function. This would convert flags like
-eto--e. This means if any other project imports beats, it's argument parsing would be changed. This change adds an allowed list of arguments that can be changed and moves it out of init.Beats currently detects if it is
fleet managedby looking at the command line flags. This change keeps that behavior, but adds the ability to set this directly. This allows setting the flag without the command line option.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
The goal is none, however if any flags are missed, then the user would have to call them as
--flaginstead of-flag.Author's Checklist
elastic-agentelastic-agentapm-serverHow to test this PR locally
Related issues
Use cases
Screenshots
Logs