[8.x](backport #41076) fix go vet errors with Go 1.24 #41336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix go vet errors with Go 1.24 The cmd/vet in Go 1.24 reports printf calls with non-const format and no args, causing failures. ``` $ go install golang.org/dl/gotip@latest $ gotip download $ gotip vet ./... ``` * use os.WriteFile * more linter fixes * even more linter fixes * more more more linter fixes * fix wrong variable name * fix linter issues with emptyIface (cherry picked from commit 5de2287)
mergify
bot
requested review from
MichaelKatsoulis and
tetianakravchenko
and removed request for
a team
botelastic
bot
added
the
needs_team
mergify
bot
requested review from
mauri870 and
khushijain21
and removed request for
a team
|
This pull request has not been merged yet. Could you please review and merge it @mauri870? 🙏 |
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
nfritts
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The cmd/vet in Go 1.24 reports printf calls with non-const format and no args, causing failures. Additionally, I had to resolve linter issues in the affected files. One particular linter error was actually a vulnerability related to path traversal for zip and tar files.
See https://go.dev/issues/60529
How to test this PR locally
Related issues
This is an automatic backport of pull request fix go vet errors with Go 1.24 #41076 done by Mergify.