Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-structform to 0.0.4 #7444

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Update go-structform to 0.0.4 #7444

merged 1 commit into from
Jun 27, 2018

Conversation

urso
Copy link

@urso urso commented Jun 27, 2018 •
edited
Loading

  • Update go-structform to version 0.0.4. New version adds support to disable HTML escaping (used in follow up PR Html escaping #7445)

@urso urso added the review label Jun 27, 2018
@ph
Copy link
Contributor

ph commented Jun 27, 2018

@urso Can you add in the commit message what changed in 0.0.4? It just easier when you go through commit history when looking for bugs.

@urso
Copy link
Author

urso commented Jun 27, 2018

@ph Nothing really. But see followup PR #7445

@urso urso mentioned this pull request Jun 27, 2018
Merged
ph
ph approved these changes Jun 27, 2018
View reviewed changes
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ph
Copy link
Contributor

ph commented Jun 27, 2018

@urso I was missing the followup PR.

@ph ph merged commit d1fbad9 into elastic:master Jun 27, 2018
@urso urso deleted the upd/go-structform-0.0.4 branch February 19, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph ph ph approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urso @ph