Add Regal Rego linting to project #326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello elastic friends! 👋😃 Good to see so many familiar faces in the list of contributors here. [Regal](https:/StyraInc/regal) is a linter for Rego, and it's reaching a level of maturity where I feel confident putting it to use in some serious policy libraries. Besides linting, the CI integration helps annotate PRs with violations at the location they happened, helping developers quickly figure out what they need to change. As part of integrating the linter in this repo, I went ahead and fixed a number of issues reported. Naturally, I've made sure that all the Rego tests pass, but if there's any change you feel was too invasive, or perhaps changed code that some other project depend on, do let me know and I'll be happy to revert that. Issues fixed for the following rules: * [not-equals-in-loop](https://docs.styra.com/regal/rules/bugs/not-equals-in-loop) * [unconditional-assignment](https://docs.styra.com/regal/rules/style/unconditional-assignment) * [use-in-operator](https://docs.styra.com/regal/rules/idiomatic/use-in-operator) * [redundant-alias](https://docs.styra.com/regal/rules/imports/redundant-alias) * [no-whitespace-comment](https://docs.styra.com/regal/rules/style/no-whitespace-comment) * [constant-condition](https://docs.styra.com/regal/rules/bugs/constant-condition) * [non-raw-regex-pattern](https://docs.styra.com/regal/rules/idiomatic/non-raw-regex-pattern) * [redundant-alias](https://docs.styra.com/regal/rules/imports/redundant-alias) Many issues, primarily related to style, have been disabled in the Regal config for now, and I'm sure you'll want to work on having some of them enabled later. Have a great weekend! Signed-off-by: Anders Eknert <[email protected]>
|
💚 CLA has been signed |
|
This pull request does not have a backport label. Could you fix it @anderseknert? 🙏
|
|
@anderseknert Thank you for your contribution, this is amazing! Sorry for the delayed response, we just merged this repo into the main cloudbeat repo: elastic/cloudbeat#1405. We are not going to update the main branch of this repo anymore, can you please re-create your PR in cloudbeat repo: https:/elastic/cloudbeat. I am going to close this PR for this reason, but I just want to repeat that your contribution is super welcome 👍 |
|
Oh, I see, @orestisfl. I'll look into that then, and will submit a PR against that repo 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Elastic friends! 👋😃 Good to see so many familiar faces in the list of contributors here. Regal is a linter for Rego, and it's reaching a level of maturity where I feel confident putting it to use in some serious policy libraries.
Besides linting, the CI integration helps annotate PRs with violations at the location they happened, helping developers quickly figure out what they need to change.
As part of integrating the linter in this repo, I went ahead and fixed a number of issues reported. Naturally, I've made sure that all the Rego tests pass, but if there's any change you feel was too invasive, or perhaps changed code that some other project depend on, do let me know and I'll be happy to revert that.
Issues fixed for the following rules:
Many issues, primarily related to style, have been disabled in the Regal config for now, and I'm sure you'll want to work on having some of them enabled later.
Have a great weekend!