Azure rule 9.4 property change #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @jeniawhite? 🙏
|
orestisfl
approved these changes
Oct 25, 2023
| data_adapter.properties.clientCertEnabled == true | ||
| # Benchmark and Azure implementation in remediation checks previous implemented value | ||
| # Reading the description and rule metadata, we've decided to check the value of the property clientCertMode | ||
| data_adapter.properties.clientCertMode == "Required" |
There was a problem hiding this comment.
Should we also check the data_adapter.properties.clientCertEnabled value for completeness/sanity?
There was a problem hiding this comment.
It is part of the schema of the ARG.
If the value doesn't exist it will be evaluated as false, do we want to have no evaluation in that case?
There was a problem hiding this comment.
In which case should it not exist?
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 1f7142b)
jeniawhite
added a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit 1f7142b) Co-authored-by: Evgeniy Belyi <[email protected]>
orestisfl
pushed a commit
to orestisfl/csp-security-policies
that referenced
this pull request
Oct 30, 2023
orestisfl
pushed a commit
to orestisfl/csp-security-policies
that referenced
this pull request
Oct 30, 2023
elastic#330 ---NOTE--- This is an imported commit, it was initially committed to the csp-security-policies repo which was then merged into cloudbeat. See: elastic/cloudbeat#1405
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of your changes
We've decided to change the checked property after reading the description and the actual rule.
The previous implementation followed the CIS remediation and Azure's implementation.
Related Issues
Checklist
Introducing a new rule?