This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
k8s-autodiscovery: notify in slack #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @v1v? 🙏
|
mergify
bot
added
the
backport-skip
reakaleek
approved these changes
Sep 18, 2023
amannocci
approved these changes
Sep 18, 2023
gizas
reviewed
Sep 19, 2023
| @@ -58,4 +58,4 @@ jobs: | |||
| vaultUrl: ${{ secrets.VAULT_ADDR }} | |||
| vaultRoleId: ${{ secrets.VAULT_ROLE_ID }} | |||
| vaultSecretId: ${{ secrets.VAULT_SECRET_ID }} | |||
| slackChannel: "#observablt-bots" | |||
| slackChannel: "#obs-cloud-monitoring" | |||
There was a problem hiding this comment.
Suggested change
| slackChannel: "#obs-cloud-monitoring" | |
| slackChannel: "#cloudnative-sdh-alarm" |
The #obs-cloud-monitor channel is a wider channel for cloud issues. Maybe this alarms can add too much noise
I would say to use #cloudnative-sdh-alarm, an "internal channel" of former cloudnative team that was used to track sdhs and various automated notifications.
@tommyers-elastic , @ChrsMark any ideas?
Co-authored-by: Andrew Gizas <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Notify a different slack channel when the k8s-autodiscovery failed
Why is it important?
Help with notifying the team who owns those tests.
Part of #3642