Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Report unexpected status codes as errors #3835

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

rdner
Copy link
Member

@rdner rdner commented May 8, 2024

The only expected code is 200, the rest should fail and the error message should contain the status code itself.

This is a follow up to #3834

The only expected code is 200, the rest should fail and the error
message should contain the status code itself.
@rdner rdner requested review from ycombinator and cmacknz May 8, 2024 09:26
@rdner rdner self-assigned this May 8, 2024
@rdner rdner added Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels May 8, 2024
Copy link
Contributor

mergify bot commented May 8, 2024

This pull request does not have a backport label. Could you fix it @rdner? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label May 8, 2024
@rdner rdner enabled auto-merge (squash) May 8, 2024 14:46
@rdner rdner merged commit a27ba8e into main May 8, 2024
5 checks passed
@ycombinator ycombinator deleted the better-http-code-reporting branch May 8, 2024 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants